[Stingray][TvDeck] Add onscanningstatechanged event by using addEventListener

RESOLVED FIXED

Status

Firefox OS
Gaia::TV
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sungchiu, Assigned: sungchiu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In TVDeck, callback function for TVSource onscanningstatechanged event is directly assigned. It would be better to use addEventListenr to add callback functions. Need to find a way to not add duplicate callback functions for every TVSource.
Created attachment 8595237 [details] [review]
[gaia] sean2449:Bug_1156185-eventListener > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8595237 [details] [review]
[gaia] sean2449:Bug_1156185-eventListener > mozilla-b2g:master

1. onscanningstatechanged event is added by using addEventListener.
2. ontunerchanged event is removed since our Gecko has remove this API.
Attachment #8595237 - Flags: review?(im)
Comment on attachment 8595237 [details] [review]
[gaia] sean2449:Bug_1156185-eventListener > mozilla-b2g:master

I found an issue with this patch. Please find my comments at PR.
Attachment #8595237 - Flags: review?(im)
(Assignee)

Updated

3 years ago
Component: Gaia → Gaia::TV
(Assignee)

Comment 4

3 years ago
Comment on attachment 8595237 [details] [review]
[gaia] sean2449:Bug_1156185-eventListener > mozilla-b2g:master

John, I have applied the change. ontunerchanged event is removed from Gecko.
Attachment #8595237 - Flags: review?(im)
Comment on attachment 8595237 [details] [review]
[gaia] sean2449:Bug_1156185-eventListener > mozilla-b2g:master

looks good to me.
Attachment #8595237 - Flags: review?(im) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.