Closed Bug 1156185 Opened 10 years ago Closed 10 years ago

[Stingray][TvDeck] Add onscanningstatechanged event by using addEventListener

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: suchiu, Assigned: suchiu)

References

Details

Attachments

(1 file)

[gaia] sean2449:Bug_1156185-eventListener > mozilla-b2g:master
46 bytes, text/x-github-pull-request
johnhu
: review+
Details | Review
In TVDeck, callback function for TVSource onscanningstatechanged event is directly assigned. It would be better to use addEventListenr to add callback functions. Need to find a way to not add duplicate callback functions for every TVSource.
Comment on attachment 8595237 [details] [review] [gaia] sean2449:Bug_1156185-eventListener > mozilla-b2g:master 1. onscanningstatechanged event is added by using addEventListener. 2. ontunerchanged event is removed since our Gecko has remove this API.
Attachment #8595237 - Flags: review?(im)
Comment on attachment 8595237 [details] [review] [gaia] sean2449:Bug_1156185-eventListener > mozilla-b2g:master I found an issue with this patch. Please find my comments at PR.
Attachment #8595237 - Flags: review?(im)
Component: Gaia → Gaia::TV
Comment on attachment 8595237 [details] [review] [gaia] sean2449:Bug_1156185-eventListener > mozilla-b2g:master John, I have applied the change. ontunerchanged event is removed from Gecko.
Attachment #8595237 - Flags: review?(im)
Comment on attachment 8595237 [details] [review] [gaia] sean2449:Bug_1156185-eventListener > mozilla-b2g:master looks good to me.
Attachment #8595237 - Flags: review?(im) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: