Implement Brick Test in JavaScript

RESOLVED WONTFIX

Status

defect
RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: Silne30, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reporter

Description

4 years ago
Adding MarionetteJS brick test to verify home screen.
Reporter

Updated

4 years ago
Assignee: nobody → jdorlus
Reporter

Updated

4 years ago
Status: NEW → ASSIGNED
Reporter

Updated

4 years ago
QA Whiteboard: [fxosqa-auto-s14+]
Reporter

Updated

4 years ago
Attachment #8596723 - Flags: review?(jlorenzo)
Reporter

Updated

4 years ago
Attachment #8596723 - Flags: review?(martijn.martijn)
Depends on: 1145657
Comment on attachment 8596723 [details] [review]
[gaia] silne30:Bug_1156332-Implement_Brick_Test_JS > mozilla-b2g:master

Per your commit history, you need the work you're doing in bug 1145657, to make this test passing. The PR as-is will be rejected by autolander[1] and, if we merged it today, it would create some conflicts when we'd like to land bug 1145657.

That said, I've reviewed the commit which adds the particular brick test.  This looks like a good start. I couldn't test it on device (my screen remains black) and b2gdesktop is too fast for me to see if the homescreen is correctly loaded or not. I think we can improve the style a bit more, for this first test which will pave the way to the other acceptance tests. I also left a couple of questions.

I'm clearing the review as the test is on a good way, but needs to change due to bug 1145657.

[1] https://github.com/mozilla/autolander#autolander
Attachment #8596723 - Flags: review?(jlorenzo)
Sorry my review takes so long, but I don't really know this stuff well.

But if I understand correctly and is this pull request also incorporating what bug 1145657 is about?
Reporter

Updated

4 years ago
QA Whiteboard: [fxosqa-auto-s14+] → [fxosqa-auto-s14+,s15,s16,s17]
Comment on attachment 8596723 [details] [review]
[gaia] silne30:Bug_1156332-Implement_Brick_Test_JS > mozilla-b2g:master

Clearing review request here. Just readd me for review if you need a new review.
Attachment #8596723 - Flags: review?(martijn.martijn)
Reporter

Comment 5

3 years ago
I don't think this is still going to be of value.
Reporter

Updated

3 years ago
Assignee: jdorlus → nobody
Status: ASSIGNED → NEW
Reporter

Comment 6

3 years ago
Do we still need this test?
Flags: needinfo?(jlorenzo)
That's correct, we don't need it anymore. Like bug 1145657, let's close this one.
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(jlorenzo)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.