Closed Bug 1156332 Opened 5 years ago Closed 5 years ago
Implement Brick Test in Java
46 bytes, text/x-github-pull-request
|Details | Review|
Adding MarionetteJS brick test to verify home screen.
Depends on: 1145657
Comment on attachment 8596723 [details] [review] [gaia] silne30:Bug_1156332-Implement_Brick_Test_JS > mozilla-b2g:master Per your commit history, you need the work you're doing in bug 1145657, to make this test passing. The PR as-is will be rejected by autolander and, if we merged it today, it would create some conflicts when we'd like to land bug 1145657. That said, I've reviewed the commit which adds the particular brick test. This looks like a good start. I couldn't test it on device (my screen remains black) and b2gdesktop is too fast for me to see if the homescreen is correctly loaded or not. I think we can improve the style a bit more, for this first test which will pave the way to the other acceptance tests. I also left a couple of questions. I'm clearing the review as the test is on a good way, but needs to change due to bug 1145657.  https://github.com/mozilla/autolander#autolander
Sorry my review takes so long, but I don't really know this stuff well. But if I understand correctly and is this pull request also incorporating what bug 1145657 is about?
QA Whiteboard: [fxosqa-auto-s14+] → [fxosqa-auto-s14+,s15,s16,s17]
Comment on attachment 8596723 [details] [review] [gaia] silne30:Bug_1156332-Implement_Brick_Test_JS > mozilla-b2g:master Clearing review request here. Just readd me for review if you need a new review.
I don't think this is still going to be of value.
Assignee: jdorlus → nobody
Status: ASSIGNED → NEW
Do we still need this test?
That's correct, we don't need it anymore. Like bug 1145657, let's close this one.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.