1156332 - Implement Brick Test in JavaScript

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[John Dorlus [:Silne30]]

Adding MarionetteJS brick test to verify home screen.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] silne30:Bug_1156332-Implement_Brick_Test_JS > mozilla-b2g:master

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8596723 [details] [review]
[gaia] silne30:Bug_1156332-Implement_Brick_Test_JS > mozilla-b2g:master

Per your commit history, you need the work you're doing in bug 1145657, to make this test passing. The PR as-is will be rejected by autolander[1] and, if we merged it today, it would create some conflicts when we'd like to land bug 1145657.

That said, I've reviewed the commit which adds the particular brick test.  This looks like a good start. I couldn't test it on device (my screen remains black) and b2gdesktop is too fast for me to see if the homescreen is correctly loaded or not. I think we can improve the style a bit more, for this first test which will pave the way to the other acceptance tests. I also left a couple of questions.

I'm clearing the review as the test is on a good way, but needs to change due to bug 1145657.

[1] https://github.com/mozilla/autolander#autolander

Comment 3

[Martijn Wargers (dead)]

Sorry my review takes so long, but I don't really know this stuff well.

But if I understand correctly and is this pull request also incorporating what bug 1145657 is about?

Comment 4

[Martijn Wargers (dead)]

Comment on attachment 8596723 [details] [review]
[gaia] silne30:Bug_1156332-Implement_Brick_Test_JS > mozilla-b2g:master

Clearing review request here. Just readd me for review if you need a new review.

Comment 5

[John Dorlus [:Silne30]]

I don't think this is still going to be of value.

Comment 6

[John Dorlus [:Silne30]]

Do we still need this test?

Comment 7

[Johan Lorenzo [:jlorenzo]]

That's correct, we don't need it anymore. Like bug 1145657, let's close this one.