Closed Bug 1156392 Opened 10 years ago Closed 9 years ago

Remove MOZ_ANDROID_APZ condition from ifdef in ScrollFrameHelper::WantAsyncScroll

Categories

(Core :: Layout, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1146024#c7 (second paragraph) for backstory - nsGfxScrollFrame::WantAsyncScroll uses the presence of scrollbars to determine if something should be async-scrollable, and in Fennec we have the scrollbars set to display:none in content.css (because we draw them in Java). Eventually we should rip out the Java scrollbars and use the Gecko ones like we do everywhere else, at which point we can restore WantAsyncScroll to the way it was prior to bug 1146024 (i.e. remove the MOZ_ANDROID_APZ component of the ifdef).
OS: Mac OS X → Android
Hardware: x86 → All
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Actually I'm going to repurpose this bug for the last bit of comment (removing the ifdef condition), which hasn't been done yet.
Blocks: 1146024
Status: RESOLVED → REOPENED
No longer depends on: 1146024
Resolution: DUPLICATE → ---
Summary: Enable gecko scrollbars for Fennec w/APZ → Remove MOZ_ANDROID_APZ condition from ifdef in ScrollFrameHelper::WantAsyncScroll
Assignee: nobody → bugmail.mozilla
Component: Widget: Android → Layout
Depends on: 1223928
Attached patch PatchSplinter Review
We can take out the MOZ_ANDROID_APZ condition here now that we have gecko scrollbars enabled in android-apz.
Attachment #8694242 - Flags: review?(tnikkel)
Attachment #8694242 - Flags: review?(tnikkel) → review+
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: