115650 - No TITLE attribute on buglinks on process_bug.cgi.

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement, P3)

Description

[Tobias B. Besemer [:BesTo] (QA)]

When I make changes to a bug and posting them I've see the bugs this bug depends on.
It will be fine to have to each bug-link a title to see whats the bug about.

Comment 1

[Dave Miller [:justdave]]

This is fixed by the patch on bug 72863, btw.  It doesn't use the method
requested in bug 115796, however.

Comment 2

[Jens Bech Madsen]

Or the summary of the bug could just be displayed after the 'Changes
submitted'/'Checking for dependency' etc lines.

I changed that in process_bug.cgi with two lines in 2.14, but I see no way of
doing it in a sensible way now that it is done with templates.

Comment 3

[Dave Miller [:justdave]]

The User Interface component now belongs to Gerv.  Reassigning all UNCONFIRMED
and NEW (but not ASSIGNED) bugs currently owned by Myk (the previous component
owner) to Gerv.

Comment 4

[Dave Miller [:justdave]]

Reassigning back to Myk.  That stuff about Gerv taking over the User Interface
component turned out to be short-lived.  Please pardon our confusion, and I'm
very sorry about the spam.

Comment 5

[Dave Miller [:justdave]]

Enhancements which don't currently have patches on them which are targetted at
2.18 are being retargetted to 2.20 because we're about to freeze for 2.18. 
Consideration will be taken for moving items back to 2.18 on a case-by-case
basis (but is unlikely for enhancements)

Comment 6

[Dave Miller [:justdave]]

Bugzilla 2.20 feature set is now frozen as of 15 Sept 2004.  Anything flagged
enhancement that hasn't already landed is being pushed out.  If this bug is
otherwise ready to land, we'll handle it on a case-by-case basis, please set the
blocking2.20 flag to '?' if you think it qualifies.

Comment 7

[Frédéric Buclin]

The trunk is now frozen to prepare Bugzilla 2.22. Only bug fixes are accepted, no enhancement bugs. As this bug has a pretty low activity (especially from the assignee), it's retargetted to ---. If you want to work on it and you think you can have it fixed for 2.24, please retarget it accordingly (to 2.24).

Comment 8

[victory <[e-mail]>]

Attachment: patch for tip

didn't find how it appears so didn't check dupe.. :-P

Comment 9

[Frédéric Buclin]

Comment on attachment 237607 [details] [diff] [review]
patch for tip

>Index: template/en/default/bug/process/midair.html.tmpl

>-    <a href="show_bug.cgi?id=[% bug_id %]">Throw away my changes,
>-      and revisit [% terms.bug %] [%+ bug_id %]</a>
>+    [% "Throw away my changes, and revisit $terms.bug $bug_id" FILTER bug_link(bug_id) %]</a>

Nit: not sure the whole sentence should be linkified.


The reason for r- is that this patch doesn't pass test 008filter.t.

Comment 10

[victory <[e-mail]>]

Attachment: patch for tip v2

take #9

Comment 11

[Frédéric Buclin]

Comment on attachment 239113 [details] [diff] [review]
patch for tip v2

>Index: template/en/default/bug/process/confirm-duplicate.html.tmpl

>+  <b>Adding the reporter to the CC list of
>+  [% "$terms.bug $original_bug_id"
>+     FILTER bug_link(original_bug_id) FILTER none %]
>   [% IF cclist_accessible %]
>     will immediately
>   [% ELSE %]
>     might, in the future,
>   [% END %]
>-  allow him/her access to view this [% terms.bug %].</b>
>+  allow him/her access to view
>+  [% "$terms.bug $duplicate_bug_id"
>+     FILTER bug_link(duplicate_bug_id) FILTER none %].</b>
>   Do you wish to do this?

You already linkify the bug # at the beginning of this sentence; there is no need to change "view this bug" as the sentence is explicit enough and already contains a link to the oringinal bug. Moreover, your change is incorrect as it should point to the original bug anyway, not the dupe.

Your patch has bitrotten. Else it looks good, but I couldn't test it.

Comment 12

[victory <[e-mail]>]

Attachment: v3

isnt sure what he meant

Comment 13

[Frédéric Buclin]

Comment on attachment 245533 [details] [diff] [review]
v3

>Index: template/en/default/bug/process/midair.html.tmpl

>-    <a href="show_bug.cgi?id=[% bug_id %]">Throw away my changes,
>-      and revisit [% terms.bug %] [%+ bug_id %]</a>
>+    [% "Throw away my changes, and revisit $terms.bug $bug_id"
>+        FILTER bug_link(bug_id) FILTER none %]

Maybe shouldn't we link the whole sentence, but only "revisit bug ###". This could be fixed on checkin. r=LpSolit

Comment 14

[Frédéric Buclin]

just on time for 3.0.

Comment 15

[Frédéric Buclin]

Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.90; previous revision: 1.89
done
Checking in template/en/default/bug/process/confirm-duplicate.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/confirm-duplicate.html.tmpl,v  <--  confirm-duplicate.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/bug/process/midair.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/midair.html.tmpl,v  <--  midair.html.tmpl
new revision: 1.19; previous revision: 1.18
done