1156588 - "ASSERTION: not in child list" with grid, white-space:pre

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

With:
  user_pref("layout.css.grid.enabled", true);

###!!! ASSERTION: not in child list: 'found', file layout/base/nsLayoutUtils.cpp, line 1231

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Mats Palmgren (inactive)]

This verification DEBUG code is a bit out-of-date now that
nsInlineFram::Insert/Append/RemoveFrame deals with being called
on the wrong parent.
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.cpp?rev=023fdd5ebd3f#1212

It's unrelated to Grid, but probably easier to reproduce there
since it doesn't handle incomplete children yet, so it's easy
to trigger OverflowLists laying around.

If someone wants to take a stab at fixing this: add a loop at the
end of this DEBUG block that also checks the GetNextInFlow chain
of 'parent' (if it's an nsInlineFrame).

Comment 3

[Ryan VanderMeulen [:RyanVM]]

The attached testcase no longer asserts. Leaving the bug open per comment 2, however.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f176a0a3265

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3f176a0a3265

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Mats, is comment 2 still valid?

Comment 7

[Mats Palmgren (inactive)]

Yeah, it was probably a false positive, but I'm fine leaving the assertion as is.
I'll investigate again if we get another testcase that triggers it...

Comment 8

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.