1156606 - Use WheelScrollAnimation for instant scrolling, too

Status: RESOLVED WORKSFORME

(Core :: Panning and Zooming, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

ESM uses its async scroll animation for instant scrolling, too - it just moves to the destination in one frame, skipping the timing function. This is easy enough to do in APZ and gets rid of a bunch of code.

The motivation for this was that using pan-gestures can leave the last repaint request stuck in the throttling queue, which led to intermittent timeouts on some mochitests. I can't reproduce that with this patch, but I'm not sure if this actually guarantees it's fixed.

Either way I'm happy to not rely on the panning code for wheel scrolling.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8595125 [details] [diff] [review]
patch

This caused another test to start failing... clearing review for now.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

FWIW I do like the simplification in this patch, and the removal of the pangesture events.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

(In reply to David Anderson [:dvander] from comment #2)
> Comment on attachment 8595125 [details] [diff] [review]
> patch
> 
> This caused another test to start failing... clearing review for now.

Do you happen to recall which test was failing with this?

Comment 5

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f4357d32e52

Comment 6

[Markus Stange [:mstange]]

It fails the GTest from bug 1166871.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

This is fixed via bug 1193602.