Closed Bug 1156607 Opened 9 years ago Closed 9 years ago

Fix remaining FTU jshint issues

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::First Time Experience
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

[gaia] KevinGrandon:bug_1156607_ftu_jshint > mozilla-b2g:master
46 bytes, text/x-github-pull-request
sfoster
: review+
Details | Review 
Which means removing these files from xfail.list: https://github.com/mozilla-b2g/gaia/blob/0645bbed4d6cbd8064652eebafe011edc3e417fd/build/jshint/xfail.list#L15-L31

We're getting close to being done with jshint fixes and can kill off some legacy code once we do so. Let's push this through!
Hey Sam - I'm looking at trying to have all of these jshint failures cleaned up in the next few weeks. Just wondering if you wanted to take this before I jumped on it. (If not I'll gladly take this and maybe request a review from you.) Thanks!
Flags: needinfo?(sfoster)
Whiteboard: [systemsfe]
(In reply to Kevin Grandon :kgrandon from comment #1)
> Hey Sam - I'm looking at trying to have all of these jshint failures cleaned
> up in the next few weeks. Just wondering if you wanted to take this before I
> jumped on it. (If not I'll gladly take this and maybe request a review from
> you.) Thanks!

I started work on bug 1036697, which will move that ftu tutorial_test.js file and can fix up the lint errors in it while I'm in there. If you do get to it first it shouldnt be a big deal to unconflict. For the rest, I've got a couple blockers but I can probably get started later this week. So, up to you. I'm happy to own it, but will review if you want to get it done sooner.
Flags: needinfo?(sfoster)
I will take this, hopefully this won't bitrot anything you're working on too badly.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Comment on attachment 8598227 [details] [review]
[gaia] KevinGrandon:bug_1156607_ftu_jshint > mozilla-b2g:master

Sam - could you take a look when you get a chance? Thanks!
Attachment #8598227 - Flags: review?(sfoster)
Comment on attachment 8598227 [details] [review]
[gaia] KevinGrandon:bug_1156607_ftu_jshint > mozilla-b2g:master

Tests are green, minimal impact to non-test code and pretty much just clean-up in the tests. What's not to like - thanks!
Attachment #8598227 - Flags: review?(sfoster) → review+
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#iEPe4xckRMakZU3hbVoO7g

The pull request failed to pass integration tests. It could not be landed, please try again.
http://docs.taskcluster.net/tools/task-graph-inspector/#iqY0O9kaSAiSxiX39Y46Gg

The pull request failed to pass integration tests. It could not be landed, please try again.
TC issues seem resolved now. Trying again.
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#jgDNozIFQcesjhVSv7Zvkg

The pull request failed to pass integration tests. It could not be landed, please try again.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: