1156615 - (Browser API) ctrl/cmd/middle-click doesn't work if <a> element has children

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Paul Rouget [:paul]]

<a>foo</a> works. <a><span>foo</span></a> doesn't.

Comment 1

[Paul Rouget [:paul]]

We should implement something similar to `hrefAndLinkNodeForClickEvent` (browser/base/content/browser.js).

Comment 2

[Paul Rouget [:paul]]

Attachment: v1

Comment 3

[Boris Zbarsky [:bzbarsky, bz on IRC]]

That doesn't seem right to me.  If I have an <input> inside <a> and I middle-click on Linux to paste into it, won't this patch try to open the anchor href in a new tab?

Comment 4

[Paul Rouget [:paul]]

(In reply to Not doing reviews right now from comment #3)
> That doesn't seem right to me.  If I have an <input> inside <a> and I
> middle-click on Linux to paste into it, won't this patch try to open the
> anchor href in a new tab?

B2G on Linux doesn't appear to support middle click for pasting.

If that's alright, I'd like to land this patch and file a follow-up bug to support pasting with middle click on Linux. Or maybe you have an idea of a better way to support middle click to open a link in a new tab.

Comment 5

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Followup sounds fine as long as something is tracking this.  It's worth looking at what Firefox does here...

Comment 6

[Paul Rouget [:paul]]

Paste with middle click: bug 1158101.

Comment 7

[Paul Rouget [:paul]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8bb7223ea7fc

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/c01be883059b

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c01be883059b