Closed Bug 1156628 Opened 5 years ago Closed 5 years ago

Don't use MOZ_MALLOC_OPTIONS="ff" on B2G desktop

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: paul, Assigned: paul)

References

Details

Attachments

(1 file, 3 obsolete files)

MOZ_MALLOC_OPTIONS "ff" should be only used on device.
Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #8595154 - Flags: review?(gsvelto)
Comment on attachment 8595154 [details] [diff] [review]
v1

wrong ifdef…
Attachment #8595154 - Flags: review?(gsvelto)
Attached patch v1 (obsolete) — Splinter Review
Attachment #8595154 - Attachment is obsolete: true
Attachment #8595158 - Flags: review?(gsvelto)
Comment on attachment 8595158 [details] [diff] [review]
v1

Redirecting to Mike who reviewed the original patch. This LGTM but a better patch comment would be something like: "Don't limit the number of unused dirty pages kept by jemalloc on B2G desktop" which describes more clearly why we're doing this.

Note that the rationale behind enabling this for desktop too was that people used the desktop version as a proxy to measure memory used by applications (bug 805855 comment 19). I think this doesn't hold true anymore, practically all app development happens on devices and memory profiling definitely does (Nuwa and other changes made memory use very different than on the desktop).
Attachment #8595158 - Flags: review?(gsvelto) → review?(mh+mozilla)
Comment on attachment 8595158 [details] [diff] [review]
v1

Review of attachment 8595158 [details] [diff] [review]:
-----------------------------------------------------------------

Relevant: bug 811740 comment 22 to 24.

Please also change memory/build/jemalloc_config.c
Attachment #8595158 - Flags: review?(mh+mozilla) → feedback+
Attached patch v2 (obsolete) — Splinter Review
Attachment #8595158 - Attachment is obsolete: true
Attachment #8596438 - Flags: review?(mh+mozilla)
Attachment #8596438 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/63895748c94e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Blocks: graphene
You need to log in before you can comment on or make changes to this bug.