1156628 - Don't use MOZ_MALLOC_OPTIONS="ff" on B2G desktop

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Paul Rouget [:paul]]

MOZ_MALLOC_OPTIONS "ff" should be only used on device.

Comment 1

[Paul Rouget [:paul]]

Attachment: v1

Comment 2

[Paul Rouget [:paul]]

Comment on attachment 8595154 [details] [diff] [review]
v1

wrong ifdef…

Comment 3

[Paul Rouget [:paul]]

Attachment: v1

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8595158 [details] [diff] [review]
v1

Redirecting to Mike who reviewed the original patch. This LGTM but a better patch comment would be something like: "Don't limit the number of unused dirty pages kept by jemalloc on B2G desktop" which describes more clearly why we're doing this.

Note that the rationale behind enabling this for desktop too was that people used the desktop version as a proxy to measure memory used by applications (bug 805855 comment 19). I think this doesn't hold true anymore, practically all app development happens on devices and memory profiling definitely does (Nuwa and other changes made memory use very different than on the desktop).

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8595158 [details] [diff] [review]
v1

Review of attachment 8595158 [details] [diff] [review]:
-----------------------------------------------------------------

Relevant: bug 811740 comment 22 to 24.

Please also change memory/build/jemalloc_config.c

Comment 6

[Paul Rouget [:paul]]

Attachment: v2

Comment 7

[Paul Rouget [:paul]]

Attachment: v2 with better commit message

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8bb7223ea7fc

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/63895748c94e

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/63895748c94e