1156629 - Core GL profiles require default VAO.

Status: RESOLVED FIXED

Description

[Dan Glastonbury (:kamidphish) | needinfo me]

Comment 1

[Dan Glastonbury (:kamidphish) | needinfo me]

Created attachment 8595155 [details] [diff] [review]
OpenGL core context deprecated default VAO. r=jgilbert

Create a VAO and attach it to the default object.

Comment 2

[Jeff Gilbert [:jgilbert]]

Comment on attachment 8595155 [details] [diff] [review]
OpenGL core context deprecated default VAO. r=jgilbert

Review of attachment 8595155 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContextValidate.cpp
@@ +1949,5 @@
>      mDefaultVertexArray->mAttribs.SetLength(mGLMaxVertexAttribs);
>      mBoundVertexArray = mDefaultVertexArray;
>  
> +    // Core profiles don't provide a default VBO. (Well this appears to be the
> +    // behaviour exhibited on Mac OSX OpenGL core contexts.)

I believe this is correct. Could you find the spec reference for this, though?

Comment 3

[Dan Glastonbury (:kamidphish) | needinfo me]

(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> I believe this is correct. Could you find the spec reference for this,
> though?

After much hunting I found it in GL Spec 4.0.0: (https://www.opengl.org/registry/doc/glspec40.core.20100311.pdf) in Section E.2.2 "Removed Features", pg 397:

> Client vertex and index arrays - all vertex array attribute and element array
> index pointers must refer  to buffer objects. ***The default vertex array object
> (the name zero) is also deprecated.*** Calling VertexAttribPointer when no
> buffer object or no vertex array object is bound will generate an INVALID_OPERATION
> error, as will calling any array drawing command when no vertex array object is
> bound.

So, I update the patch to only do this for version >= 4, or should we just create a VAO unconditionally for GL core profiles?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3510be31aea4

Comment 5

[Jeff Gilbert [:jgilbert]]

(In reply to Dan Glastonbury :djg :kamidphish from comment #3)
> (In reply to Jeff Gilbert [:jgilbert] from comment #2)
> > I believe this is correct. Could you find the spec reference for this,
> > though?
> 
> After much hunting I found it in GL Spec 4.0.0:
> (https://www.opengl.org/registry/doc/glspec40.core.20100311.pdf) in Section
> E.2.2 "Removed Features", pg 397:
> 
> > Client vertex and index arrays - all vertex array attribute and element array
> > index pointers must refer  to buffer objects. ***The default vertex array object
> > (the name zero) is also deprecated.*** Calling VertexAttribPointer when no
> > buffer object or no vertex array object is bound will generate an INVALID_OPERATION
> > error, as will calling any array drawing command when no vertex array object is
> > bound.
> 
> So, I update the patch to only do this for version >= 4, or should we just
> create a VAO unconditionally for GL core profiles?

Unconditional is probably better.

Comment 6

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/3510be31aea4