Closed Bug 1156631 Opened 5 years ago Closed 5 years ago

[Messages] ThreadList&Thread separation: separate CSS and image files

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: azasypkin, Assigned: azasypkin)

References

Details

(Whiteboard: [sms-sprint-2.2S11])

Attachments

(1 file)

In this bug we should move ThreadList and Thread specific CSS and image files from "/style" folder to "views/thread-list/style" and "views/thread/style" respectively.

Also we need to move view-specific rules from "style/sms.css" and "style/common.css" to appropriate view-specific CSS files ("views/thread/style/composer.css", "views/thread/style/thread.css", "views/thread-list/style/thread-list.css" for now).

At this stage it seems easier to move styles shared between Composer in Thread to views/thread/styles and in bug 1155534 split "views/thread" to "views/thread" and "views/composer".
Comment on attachment 8595163 [details] [review]
[gaia] azasypkin:bug-1156631-thread-list-and-thread-split-css > mozilla-b2g:master

Here is one more split, but it's for CSS and images. I tried to put comment for every moved CSS block so that easier to track destination.

PR consists of 3 commits, otherwise it's hard to verify changes (1st one is just for bug 1156625, please ignore it, 2nd one for file moves and 3rd one is sms.css split).

What do you think?
Attachment #8595163 - Flags: feedback?(schung)
Attachment #8595163 - Flags: feedback?(felash)
Comment on attachment 8595163 [details] [review]
[gaia] azasypkin:bug-1156631-thread-list-and-thread-split-css > mozilla-b2g:master

Thanks for the spliting and polishing! Just left some comments but I think we're moving in the right direction.
Attachment #8595163 - Flags: feedback?(schung) → feedback+
Comment on attachment 8595163 [details] [review]
[gaia] azasypkin:bug-1156631-thread-list-and-thread-split-css > mozilla-b2g:master

I left some comments, but otherwise I like it !
Attachment #8595163 - Flags: feedback?(felash) → feedback+
Depends on: 1156625
Whiteboard: [sms-sprint-2.2S11]
Comment on attachment 8595163 [details] [review]
[gaia] azasypkin:bug-1156631-thread-list-and-thread-split-css > mozilla-b2g:master

Hey guys,

I've rebased PR on the latest master and added 3rd commit to it with handled review nits and new edit-mode.css files suggested by Julien.

Thanks!
Attachment #8595163 - Flags: review?(schung)
Attachment #8595163 - Flags: review?(felash)
Comment on attachment 8595163 [details] [review]
[gaia] azasypkin:bug-1156631-thread-list-and-thread-split-css > mozilla-b2g:master

I left some simple nits on github that are worth fixing IMO: comments, and a simple selector change. r=me with this

We'll also want to move all things related to the contact prompt to a new file contact-prompt.css, we can see there are a bunch.
Attachment #8595163 - Flags: review?(felash) → review+
Comment on attachment 8595163 [details] [review]
[gaia] azasypkin:bug-1156631-thread-list-and-thread-split-css > mozilla-b2g:master

Looks great! Just some nits about the outdated comments but I'm fine if you want to keep it until polishing css(I think we might need some more time for rule naming but it's not urgent now).
Attachment #8595163 - Flags: review?(schung) → review+
Thanks for review! Nits and suggestions fixed.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.