1156650 - Show display dialog when launching app from homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Luke Chang [:lchang] (inactive)]

System app needs to be notified whenever an external display is connected and disconnected. Since system app is the only one needs this information, I propose using mozChromeEvent in lieu of inventing a new API for now.

Comment 1

[Luke Chang [:lchang] (inactive)]

We've changed the behavior of launching an app to an external display so change the title accordingly.

The detail has been updated on wiki [1]. In short, the system app should pop up a dialog to let users choose where to launch the app. For this reason, system app needs to query the current connected display list from gecko prior to showing the dialog.


[1] https://wiki.mozilla.org/Firefox_OS/1UA_Multi-Screen#Gaia

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8601977 [details] [review]
[gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master

Hi Alive,

This is a WIP patch. Could you please give us some feedback before we move on for the unit tests? Thanks a lot.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8601977 [details] [review]
[gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master

Per offline discussion canceling

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8601977 [details] [review]
[gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master

Hi Alive,

Patch is updated per our discussion. Would you mind taking a look again? Thanks.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8601977 [details] [review]
[gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master

LGTM

Comment 7

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8601977 [details] [review]
[gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master

Hi Alive,

I've finished my patch. Please help for reviewing. Thanks a log.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8601977 [details] [review]
[gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master

r+ with nits

Comment 9

[Luke Chang [:lchang] (inactive)]

Alive, Thanks. Comments are all addressed. Will land it when Bug 1163914 is ready.

Comment 10

[Luke Chang [:lchang] (inactive)]

Test passed: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=7a7e83e31b9c72fec88d5062dc2609af622c88f0

Landed on master: https://github.com/mozilla-b2g/gaia/commit/12b6953f90fe175415d99c9a55886807d5026317