Closed Bug 1156650 Opened 10 years ago Closed 10 years ago

Show display dialog when launching app from homescreen

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: lchang, Assigned: lchang)

References

Details

Attachments

(1 file)

[gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master
46 bytes, text/x-github-pull-request
alive
: review+
alive
: feedback+
Details | Review
System app needs to be notified whenever an external display is connected and disconnected. Since system app is the only one needs this information, I propose using mozChromeEvent in lieu of inventing a new API for now.
We've changed the behavior of launching an app to an external display so change the title accordingly. The detail has been updated on wiki [1]. In short, the system app should pop up a dialog to let users choose where to launch the app. For this reason, system app needs to query the current connected display list from gecko prior to showing the dialog. [1] https://wiki.mozilla.org/Firefox_OS/1UA_Multi-Screen#Gaia
Assignee: nobody → lchang
Status: NEW → ASSIGNED
Component: General → Gaia::System
Summary: Notify system app the state of external displays → Show display dialog when launching app from homescreen
Comment on attachment 8601977 [details] [review] [gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master Hi Alive, This is a WIP patch. Could you please give us some feedback before we move on for the unit tests? Thanks a lot.
Attachment #8601977 - Flags: feedback?(alive)
Comment on attachment 8601977 [details] [review] [gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master Per offline discussion canceling
Attachment #8601977 - Flags: feedback?(alive)
Comment on attachment 8601977 [details] [review] [gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master Hi Alive, Patch is updated per our discussion. Would you mind taking a look again? Thanks.
Attachment #8601977 - Flags: feedback?(alive)
Comment on attachment 8601977 [details] [review] [gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master LGTM
Attachment #8601977 - Flags: feedback?(alive) → feedback+
Blocks: 1138271
No longer blocks: 1138269
Comment on attachment 8601977 [details] [review] [gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master Hi Alive, I've finished my patch. Please help for reviewing. Thanks a log.
Attachment #8601977 - Flags: review?(alive)
Comment on attachment 8601977 [details] [review] [gaia] luke-chang:1156650_multiscreen_display_dialog > mozilla-b2g:master r+ with nits
Attachment #8601977 - Flags: review?(alive) → review+
Alive, Thanks. Comments are all addressed. Will land it when Bug 1163914 is ready.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: