Closed Bug 1156703 Opened 5 years ago Closed 4 years ago

[e10s] Detaching a 1st tab does not work if drop the 1st tab onto contents area

Categories

(Firefox :: Tabbed Browser, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
e10s m8+ ---
firefox42 --- fixed

People

(Reporter: alice0775, Assigned: smaug)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

Build Identifier:

ttps://hg.mozilla.org/mozilla-central/rev/50b95032152c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0 ID:20150420030204

Steps to reproduce:
1. Open Nightly with newly created profile
   Or, Restore previous session
   --- Now, there are several tabs opened.
2. Attempt to detach a 1st tab
   (i.e., drop the 1st tab onto contents area)


Actual Results:
Nothing happens, but page is reloaded.

Expected Results:
A new window should open with the 1st tab.

Regression window
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=63c495f3e709&tochange=1eec2c8789c1

Regressed by:
1eec2c8789c1	Olli Pettay — Bug 936092, initial DnD support for e10s, r=enndeakin,karlt
Summary: Detaching a 1st tab does not work if drop the 1st tab onto contents area → [e10s] Detaching a 1st tab does not work if drop the 1st tab onto contents area
OS: Unspecified → Windows 7
Hardware: Unspecified → x86
ah, I can see how this might happen. Investigating.
Assignee: nobody → bugs
Smaug, are you working on this? It is in our tracking list for e10s
Flags: needinfo?(bugs)
Oops, fell off my todo list.
Flags: needinfo?(bugs)
Hey Olli,
Are you still planning to do this or should we assign it to someone else?
Flags: needinfo?(bugs)
Sorry, looking at this right now.
Somehow the first xul:browser has this.droppedLinkHandler==null, so dragover handler returns too early.
Do we create the initial remote xul:browser in somehow special way?
I'll continue debugging tomorrow.
Flags: needinfo?(mconley)
Attached patch minimal patchSplinter Review
Flags: needinfo?(mconley)
Flags: needinfo?(bugs)
Attachment #8644032 - Flags: review?(felipc)
Attachment #8644032 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/9c1f10517d2a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in before you can comment on or make changes to this bug.