1156703 - [e10s] Detaching a 1st tab does not work if drop the 1st tab onto contents area

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Alice0775 White]

Build Identifier:

ttps://hg.mozilla.org/mozilla-central/rev/50b95032152c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0 ID:20150420030204

Steps to reproduce:
1. Open Nightly with newly created profile
   Or, Restore previous session
   --- Now, there are several tabs opened.
2. Attempt to detach a 1st tab
   (i.e., drop the 1st tab onto contents area)


Actual Results:
Nothing happens, but page is reloaded.

Expected Results:
A new window should open with the 1st tab.

Regression window
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=63c495f3e709&tochange=1eec2c8789c1

Regressed by:
1eec2c8789c1	Olli Pettay — Bug 936092, initial DnD support for e10s, r=enndeakin,karlt

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

ah, I can see how this might happen. Investigating.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Smaug, are you working on this? It is in our tracking list for e10s

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Oops, fell off my todo list.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Hey Olli,
Are you still planning to do this or should we assign it to someone else?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Sorry, looking at this right now.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Somehow the first xul:browser has this.droppedLinkHandler==null, so dragover handler returns too early.
Do we create the initial remote xul:browser in somehow special way?
I'll continue debugging tomorrow.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: minimal patch

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c1f10517d2a

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9c1f10517d2a