Closed Bug 1156716 Opened 10 years ago Closed 10 years ago

Build GATT backend code under Bluetooth v1

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

Product:
Firefox OS Graveyard
Component:
Bluetooth
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S11 (1may)
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(2 files, 1 obsolete file)

[01] Bug 1156716: Build GATT HAL helpers in Bluetooth v1
6.13 KB, patch
yrliou
: review+
Details | Diff | Splinter Review
[02] Bug 1156716: Build GATT backend as part of Bluetooth v1 (v2)
5.05 KB, patch
tzimmermann
: review+
Details | Diff | Splinter Review
We should build GATT backend code under Bluetooth v1 to give it some testing on try/b2g-inbound.
Comment on attachment 8595295 [details] [diff] [review] [01] Bug 1156716: Build GATT HAL helpers in Bluetooth v1 Review of attachment 8595295 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8595295 - Flags: review?(joliu) → review+
Comment on attachment 8595296 [details] [diff] [review] [02] Bug 1156716: Build GATT backend as part of Bluetooth v1 Review of attachment 8595296 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp @@ +22,1 @@ > #include "BluetoothGattManager.h" What's this for?
Attachment #8595296 - Flags: review?(joliu) → review+
(In reply to Jocelyn Liu [:jocelyn] [:joliu] from comment #5) > Comment on attachment 8595296 [details] [diff] [review] > [02] Bug 1156716: Build GATT backend as part of Bluetooth v1 > > Review of attachment 8595296 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp > @@ +22,1 @@ > > #include "BluetoothGattManager.h" > > What's this for? Hmm, The GATT profile manager might actually interfere with building v1. I better put back the ifdef statements.
Changes since v1 - don't include GATT manager in BluetoothServiceBluedroid.cpp
Attachment #8595296 - Attachment is obsolete: true
Attachment #8596430 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/e101db1ed930 https://hg.mozilla.org/mozilla-central/rev/5fa7ee34d2cb
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: