Closed
Bug 1156716
Opened 9 years ago
Closed 9 years ago
Build GATT backend code under Bluetooth v1
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S11 (1may)
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(2 files, 1 obsolete file)
6.13 KB,
patch
|
yrliou
:
review+
|
Details | Diff | Splinter Review |
5.05 KB,
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
We should build GATT backend code under Bluetooth v1 to give it some testing on try/b2g-inbound.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8595295 -
Flags: review?(joliu)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8595296 -
Flags: review?(joliu)
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c9536e4e3e5
Comment 4•9 years ago
|
||
Comment on attachment 8595295 [details] [diff] [review] [01] Bug 1156716: Build GATT HAL helpers in Bluetooth v1 Review of attachment 8595295 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8595295 -
Flags: review?(joliu) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8595296 [details] [diff] [review] [02] Bug 1156716: Build GATT backend as part of Bluetooth v1 Review of attachment 8595296 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp @@ +22,1 @@ > #include "BluetoothGattManager.h" What's this for?
Attachment #8595296 -
Flags: review?(joliu) → review+
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Jocelyn Liu [:jocelyn] [:joliu] from comment #5) > Comment on attachment 8595296 [details] [diff] [review] > [02] Bug 1156716: Build GATT backend as part of Bluetooth v1 > > Review of attachment 8595296 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp > @@ +22,1 @@ > > #include "BluetoothGattManager.h" > > What's this for? Hmm, The GATT profile manager might actually interfere with building v1. I better put back the ifdef statements.
Assignee | ||
Comment 7•9 years ago
|
||
Changes since v1 - don't include GATT manager in BluetoothServiceBluedroid.cpp
Attachment #8595296 -
Attachment is obsolete: true
Attachment #8596430 -
Flags: review+
https://hg.mozilla.org/integration/b2g-inbound/rev/e101db1ed930 https://hg.mozilla.org/integration/b2g-inbound/rev/5fa7ee34d2cb
Assignee | ||
Comment 9•9 years ago
|
||
Thanks Jocelyn. https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=5fa7ee34d2cb
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e101db1ed930 https://hg.mozilla.org/mozilla-central/rev/5fa7ee34d2cb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in
before you can comment on or make changes to this bug.
Description
•