1156807 - docker-worker: don't use default utf8 encoding for encrypted binary data

Status: RESOLVED FIXED

(Taskcluster :: Workers, defect)

Description

[Rail Aliiev [:rail]]

Attachment: PR 79: use binary encoding

Filing to track the issue in bz, see https://github.com/taskcluster/docker-worker/pull/79

Deployment of this patch may affect existing deployments that use the utf8 approach.

Comment 1

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8595397 [details] [review]
PR 79: use binary encoding

Looks awesome to me. thanks for the fix.

@garndt, will you take a look at merging this and keep rail updated on when this rolls out? I suspect he wants this for the workerType he is using.

Comment 2

[Greg Arndt [:garndt]]

I was able to pull this down and run the encrypted environment variables test and they passed.  Merged: https://github.com/taskcluster/docker-worker/commit/fab345afe693cac7b7265038690026e7e407314f

I'm going to keep this open and NI? set until I have an AMI generated and deployed.  We have a couple of other things in flight that might land at the same time as well.  I'll update this bug when worker types are updated.

Is there a particular worker type that was being used for your work right now?

Comment 3

[Rail Aliiev [:rail]]

I used b2gtest worker type, but actually there is difference which one to use.

Comment 4

[Greg Arndt [:garndt]]

new ami is on the 'ami-test' worker type to try out before we roll it out.  Let me know how it works out for you.

Comment 5

[Rail Aliiev [:rail]]

ftr