Enable Simulator configuration screen by default in WebIDE

RESOLVED FIXED in Firefox 42

Status

defect
RESOLVED FIXED
4 years ago
Last year

People

(Reporter: janx, Assigned: janx)

Tracking

({dev-doc-complete})

unspecified
Firefox 42
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed, relnote-firefox 42+)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Assignee

Description

4 years ago
Currently, to access the Simulator configuration screen in WebIDE, you need to set the following pref to true:

    devtools.webide.enableRuntimeConfiguration

To enable it by default, at least some of the following things need to be addressed first:

- Persist Simulator configurations (bug 1146519)
- Add more hardware emulation features from the device profiles
- Handle addon removal better (instead of simply deleting a configuration) (bug 1146521)
- Add visual feedback for incomplete/problematic configurations (bug 1146531)
Assignee

Updated

4 years ago
Blocks: 932758
Assignee

Comment 1

4 years ago
I'll submit this to try once a few dependency bugs are fixed.
Assignee

Comment 2

4 years ago
Attachment #8622541 - Attachment is obsolete: true
Assignee

Comment 3

4 years ago
Comment on attachment 8627763 [details] [diff] [review]
Enable Simulator configuration screen by default in WebIDE.

This is a pretty simple patch.

I'm not sure I'll have time to address all the dependencies of this bug before leaving, but maybe it makes sense to enable this feature once configurations are persistent (Bug 1146519), and leave the other dependencies as follow-ups?
Attachment #8627763 - Flags: review?(jryans)
Comment on attachment 8627763 [details] [diff] [review]
Enable Simulator configuration screen by default in WebIDE.

Review of attachment 8627763 [details] [diff] [review]:
-----------------------------------------------------------------

It seems fine to me to enable after persisting lands (bug 1146519).

Is there a bug filed to allow adding additional simulator profiles?  As it is, it seems you only get N options if you have N simulator add-ons installed, though you could redirect one of those to a different add-on from the one it started as.
Attachment #8627763 - Flags: review?(jryans) → review+
Assignee

Updated

4 years ago
Depends on: 1179142
Assignee

Comment 5

4 years ago
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #4)
> Is there a bug filed to allow adding additional simulator profiles?  As it
> is, it seems you only get N options if you have N simulator add-ons
> installed, though you could redirect one of those to a different add-on from
> the one it started as.

That's a weird UX gimmick, I agree. Filed bug 1179142 for that.
Assignee

Comment 6

4 years ago
Rebased.
Attachment #8627763 - Attachment is obsolete: true
Assignee

Comment 7

4 years ago
Comment on attachment 8628859 [details] [diff] [review]
Enable Simulator configuration screen by default in WebIDE.

Carried over.
Attachment #8628859 - Flags: review+
Assignee

Comment 8

4 years ago
Sheriffs, please land this patch along with bug 1146519 (try push for both patches is in that other bug).
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/76a9b5ea3ead
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
I've added a section on this: https://developer.mozilla.org/en-US/docs/Tools/WebIDE/Setting_up_runtimes#Configuring_Simulators. Is there anything else I ought to mention?
Flags: needinfo?(jryans)
(In reply to Will Bamberg [:wbamberg] from comment #11)
> I've added a section on this:
> https://developer.mozilla.org/en-US/docs/Tools/WebIDE/
> Setting_up_runtimes#Configuring_Simulators. Is there anything else I ought
> to mention?

Looks good!

I believe the "custom builds" page[1] can also be updated to suggest this approach, instead of setting preferences on the add-on like it currently describes.

[1]: https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Running_custom_builds_in_WebIDE#Configuring_your_simulator
Flags: needinfo?(jryans)
Thanks Ryan. I've added a note in that page, but also left the original stuff intact for the time being.
Added to the release notes:
Configurable Firefox OS Simulator in WebIDE, to simulate reference devices like phones, tablets, even TVs
with a link to https://developer.mozilla.org/en-US/docs/Tools/WebIDE/Setting_up_runtimes#Configuring_Simulators

Thanks to Jan Keromnes for bringing this to my attention

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.