1156894 - Update Firefox Account status when the Settings panel is opened

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

Right now we don't drive the Firefox Account state forward when you go to the Settings panel, so it's not very accurate.  I guess we can always push it forward.  If you're not connected, we might need to temporarily gray out the account or otherwise reflect that we're not live.

This is a UX-needed field of land mines.

Comment 1

[Nick Alexander :nalexander [he/him]]

I think we'd probably want to make this like Remote Tabs: pull-to-refresh the Account state and force a sync.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/365

st3fan: flagging you since this is a delicate interaction with the view controller lifecycle and refresh control.

The intention is to advance the Firefox Account state when opening the settings, and to allow you to pull-to-refresh the Account state.  (We'll make that do a full sync eventually.)

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8595659 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/365

This looks good to me.

Comment 4

[Nick Alexander :nalexander [he/him]]

https://github.com/mozilla/firefox-ios/commit/d30dc368e9a3d24a2cb3c70fff61d2ad9a3f82bf