Closed Bug 1156894 Opened 7 years ago Closed 7 years ago
Update Firefox Account status when the Settings panel is opened
47 bytes, text/x-github-pull-request
|Details | Review|
Right now we don't drive the Firefox Account state forward when you go to the Settings panel, so it's not very accurate. I guess we can always push it forward. If you're not connected, we might need to temporarily gray out the account or otherwise reflect that we're not live. This is a UX-needed field of land mines.
I think we'd probably want to make this like Remote Tabs: pull-to-refresh the Account state and force a sync.
st3fan: flagging you since this is a delicate interaction with the view controller lifecycle and refresh control. The intention is to advance the Firefox Account state when opening the settings, and to allow you to pull-to-refresh the Account state. (We'll make that do a full sync eventually.)
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Attachment #8595659 - Flags: review?(sarentz)
Comment on attachment 8595659 [details] [review] Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/365 This looks good to me.
Attachment #8595659 - Flags: review?(sarentz) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.