Closed Bug 1156984 Opened 11 years ago Closed 11 years ago

Jump To Definition is offered for targets outside the source tree

Categories

(Webtools Graveyard :: DXR, defect)

Product:
Webtools Graveyard
Component:
DXR
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox40 --- affected

People

(Reporter: erik, Assigned: erik)

References

Details

At http://33.33.33.77:8000/mozilla-central/source/accessible/atk/AccessibleWrap.cpp#129 (on the es branch), DXR offers a Jump To Definition context menu item on G_BEGIN_DECLS, pointing to http://33.33.33.77:8000/mozilla-central/source//usr/include/glib-2.0/glib/gmacros.h#208, which obviously doesn't exist. There should be no such offer.
Assignee: nobody → erik
Commit pushed to es at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/a994140ce557e1147ef7c75d5d297543ab5fe6a8 Don't offer definition links to things defined outside the source tree. Fixes bug 1156984.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Commit pushed to master at https://github.com/mozilla/dxr https://github.com/mozilla/dxr/commit/a994140ce557e1147ef7c75d5d297543ab5fe6a8 Don't offer definition links to things defined outside the source tree. Fixes bug 1156984.
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.