1156985 - Fix crashing xpcshell test_signed_inject.js

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop] (PTO until Aug 21st)]

This test crashes on windows: https://treeherder.mozilla.org/logviewer.html#?job_id=6806861&repo=try

Comment 1

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Attachment: patch

On Windows after the add-ons manager loads an XPI it gets held open by the zipreader cache so we have to manually flush the cache before tests can write to that file again.

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 8605328 [details] [diff] [review]
patch

Review of attachment 8605328 [details] [diff] [review]:
-----------------------------------------------------------------

r=dveditz

Comment 3

[Dave Townsend [:mossop] (PTO until Aug 21st)]

https://hg.mozilla.org/integration/fx-team/rev/c19c7176325e

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c19c7176325e

Comment 5

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Comment on attachment 8605328 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Lower automated testing
[Describe test coverage new/current, TreeHerder]: Test has been running well since landing
[Risks and why]: No risk, test only
[String/UUID change made/needed]: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/290048f1bb9a