Closed Bug 1156985 Opened 9 years ago Closed 9 years ago

Fix crashing xpcshell test_signed_inject.js

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal
Points:
2

Tracking

()

RESOLVED FIXED
mozilla41
Iteration:
41.1 - May 25
Tracking Status
firefox40 --- fixed
firefox41 --- fixed

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(1 file)

Blocks: 1038068
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Points: --- → 2
Flags: qe-verify-
Flags: firefox-backlog+
Attached patch patchSplinter Review
On Windows after the add-ons manager loads an XPI it gets held open by the zipreader cache so we have to manually flush the cache before tests can write to that file again.
Attachment #8605328 - Flags: review?(dveditz)
Comment on attachment 8605328 [details] [diff] [review]
patch

Review of attachment 8605328 [details] [diff] [review]:
-----------------------------------------------------------------

r=dveditz
Attachment #8605328 - Flags: review?(dveditz) → review+
https://hg.mozilla.org/mozilla-central/rev/c19c7176325e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Iteration: --- → 41.1 - May 25
Comment on attachment 8605328 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Lower automated testing
[Describe test coverage new/current, TreeHerder]: Test has been running well since landing
[Risks and why]: No risk, test only
[String/UUID change made/needed]: None
Attachment #8605328 - Flags: approval-mozilla-aurora?
Attachment #8605328 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.