Closed Bug 1157018 Opened 10 years ago Closed 10 years ago

Some SIM lock types that should require PUK instead require PIN

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.2+, firefox38 wontfix, firefox39 wontfix, firefox40 fixed, b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S11 (1may)
Project Flags:
blocking-b2g 2.2+
Tracking Flags:
Tracking Status
firefox38 --- wontfix
firefox39 --- wontfix
firefox40 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: pgravel, Assigned: ewu)

References

Details

Attachments

(1 file, 2 obsolete files)

8595838: Bug 1157018 - NsckPuk and PckPuk lock types that should require PUK instead require PIN. r=echenbug-1157018-v2-2.patch
882 bytes, patch
ewu
: review+
jocheng
: approval-mozilla-b2g37+
Details | Diff | Splinter Review
Two of the four lock types added in bug 1113476 (nsckPuk and pckPuk) are improperly requiring PIN entry instead of PUK entry. dom/icc/Icc.cpp::IsPukCardLockType() needs to be updated with the new lock types in order to pick up the correct password field.
OS: Unspecified → Gonk (Firefox OS)
Hardware: Unspecified → ARM
Blocks: 1113476
Assignee: nobody → ewu
triage: this breaks functionality
blocking-b2g: 2.2? → 2.2+
Attached patch bug-1157018.patch (obsolete) — — Splinter Review
add new lock type in order to support NsckPuK and PckPuk.
Attachment #8595796 - Flags: review?(sku)
Comment on attachment 8595796 [details] [diff] [review] bug-1157018.patch Review of attachment 8595796 [details] [diff] [review]: ----------------------------------------------------------------- Hi Edgar, Please help review this patch. thanks.
Attachment #8595796 - Flags: review?(sku) → review?(echen)
Comment on attachment 8595796 [details] [diff] [review] bug-1157018.patch Review of attachment 8595796 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, just one thing, please revise the commit title a bit, s/Some SIM lock types/NsckPuk and PckPuk lock types/. Thank you. And since this is a 2.2+ blocker, please also help to ask approval after landed in m-c (if this patch is conflict with 2.2 branch, you will need to provide a patch for 2.2).
Attachment #8595796 - Flags: review?(echen) → review+
https://hg.mozilla.org/mozilla-central/rev/1c4599562e78
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Please request b2g37 approval on this patch when you get a chance.
status-b2g-v2.2: --- → affected
status-b2g-master: --- → fixed
status-firefox38: --- → wontfix
status-firefox39: --- → wontfix
Flags: needinfo?(ewu)
Target Milestone: --- → 2.2 S11 (1may)
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): n/a User impact if declined: IsPukCardLockType() needs to be updated with the new lock types in order to pick up the correct password field. Testing completed: Verified on master and 2.0m. Risk to taking this patch (and alternatives if risky): Low, There are no obvious risks I can identify. String or UUID changes made by this patch:None
Attachment #8595838 - Attachment is obsolete: true
Flags: needinfo?(ewu)
Attachment #8611035 - Flags: review+
Attachment #8611035 - Flags: approval-mozilla-b2g37?
Attachment #8611035 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: