1157041 - Change tab queue notification text

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

Let's rethink the tab queue notification text!

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Firefox
1 tab waiting

Comment 2

[Martyn Haigh (:mhaigh)]

Attachment: Change tab queue notification text

Change the text and remove the necessity of having multiple notification titles.

This includes a bump for the text entries which have changed.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8595647 [details] [diff] [review]
Change tab queue notification text

Review of attachment 8595647 [details] [diff] [review]:
-----------------------------------------------------------------

Cool beans.

::: mobile/android/base/locales/en-US/android_strings.dtd
@@ +202,1 @@
>  <!-- Localization note (tab_queue_notification_text_plural) : The

Update l10n note title.

@@ +207,1 @@
>  <!-- Localization note (tab_queue_notification_text_singular) : This is the

Update l10n note.

::: mobile/android/base/tabqueue/TabQueueHelper.java
@@ +119,4 @@
>  
>          PendingIntent pendingIntent = PendingIntent.getActivity(context, 0, resultIntent, PendingIntent.FLAG_CANCEL_CURRENT);
>  
> +        String text;

nit: final

Comment 4

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/1e8c1b79132f

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1e8c1b79132f

Comment 6

[Teodora Vermesan (:TeoVermesan)]

"Nightly
1 tab waiting" notification is displayed in the android notification bar, so:
Verified as fixed using:
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 40.0a1 (2015-04-28)