Closed Bug 1157081 Opened 5 years ago Closed 5 years ago

TP is silently disabled when both malware and phishing protection are disabled

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: francois, Assigned: francois)

References

Details

Attachments

(1 file)

It should be possible to turn tracking protection ON/OFF independently of the malware/phishing components of Safe Browsing.
Assignee: nobody → francois
Status: NEW → ASSIGNED
QA Contact: mwobensmith
Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled
Attachment #8616601 - Flags: review?(sworkman)
Comment on attachment 8616601 [details]
MozReview Request: Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled. r=sworkman

https://reviewboard.mozilla.org/r/10463/#review9343

Ship It!
Attachment #8616601 - Flags: review+
Comment on attachment 8616601 [details]
MozReview Request: Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled. r=sworkman

Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled. r=sworkman
Attachment #8616601 - Attachment description: MozReview Request: Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled → MozReview Request: Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled. r=sworkman
Attachment #8616601 - Flags: review+
https://reviewboard.mozilla.org/r/10461/#review9347

On 09/06/15 13:08, Steve Workman wrote:
> I'm not sure what I'm doing wrong here but I've tried publishing my review like 4/5 times. And I hit ShipIt and nothing happened in the bug.
> 
> Looks fine to me. Just check the the TP pref is def cleaned up as part of pushPrefEnv's cleanup.

I checked that pushPrefEnv takes care of cleaning up: https://dxr.mozilla.org/mozilla-central/source/testing/specialpowers/content/specialpowersAPI.js#1010

Flagging as r+ by sworkman.
Comment on attachment 8616601 [details]
MozReview Request: Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled. r=sworkman

https://reviewboard.mozilla.org/r/10463/#review9351

Ship It!
Attachment #8616601 - Flags: review+
Keywords: checkin-needed
Where did this get r+?
Keywords: checkin-needed
Sorry, I should have been more explicit. It was r+ by sworkman in email because he tried to do it in MozReview and couldn't get it to work.
Keywords: checkin-needed
Comment on attachment 8616601 [details]
MozReview Request: Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled. r=sworkman

Seeing the flag in my dashboard; setting this manually to clear the notification.
Attachment #8616601 - Flags: review?(sworkman) → review+
https://hg.mozilla.org/mozilla-central/rev/8cf841f9a42e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.