1157081 - TP is silently disabled when both malware and phishing protection are disabled

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[François Marier [:francois]]

It should be possible to turn tracking protection ON/OFF independently of the malware/phishing components of Safe Browsing.

Comment 1

[François Marier [:francois]]

Attachment: MozReview Request: Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled. r=sworkman

Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled

Comment 2

[François Marier [:francois]]

Comment on attachment 8616601 [details]
MozReview Request: Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled. r=sworkman

https://reviewboard.mozilla.org/r/10463/#review9343

Ship It!

Comment 3

[François Marier [:francois]]

Comment on attachment 8616601 [details]
MozReview Request: Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled. r=sworkman

Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled. r=sworkman

Comment 4

[François Marier [:francois]]

https://reviewboard.mozilla.org/r/10461/#review9347

On 09/06/15 13:08, Steve Workman wrote:
> I'm not sure what I'm doing wrong here but I've tried publishing my review like 4/5 times. And I hit ShipIt and nothing happened in the bug.
> 
> Looks fine to me. Just check the the TP pref is def cleaned up as part of pushPrefEnv's cleanup.

I checked that pushPrefEnv takes care of cleaning up: https://dxr.mozilla.org/mozilla-central/source/testing/specialpowers/content/specialpowersAPI.js#1010

Flagging as r+ by sworkman.

Comment 5

[François Marier [:francois]]

Comment on attachment 8616601 [details]
MozReview Request: Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled. r=sworkman

https://reviewboard.mozilla.org/r/10463/#review9351

Ship It!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Where did this get r+?

Comment 7

[François Marier [:francois]]

Sorry, I should have been more explicit. It was r+ by sworkman in email because he tried to do it in MozReview and couldn't get it to work.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8cf841f9a42e

Comment 9

[Steve Workman [:sworkman] (INACTIVE)]

Comment on attachment 8616601 [details]
MozReview Request: Bug 1157081 - Make tracking protection work when malware and phishing protections are disabled. r=sworkman

Seeing the flag in my dashboard; setting this manually to clear the notification.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8cf841f9a42e