Closed
Bug 1157143
Opened 9 years ago
Closed 9 years ago
in-content/common.css: No indication when a menuitem is disabled
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(2 files, 2 obsolete files)
195.64 KB,
image/png
|
Details | |
2.75 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
From bug 989469 comment 148: Heycam spotted another UI problem in the current patch, the "Ask to activate" option for Open H264 is disabled but it appears enabled in the current patch.
Assignee | ||
Comment 1•9 years ago
|
||
The disabled menu/menuitems have now a opacity of 0.5 and no highlight on _moz-menuactive.
Comment 2•9 years ago
|
||
Comment on attachment 8595852 [details] [diff] [review] Bug1157143.patch Review of attachment 8595852 [details] [diff] [review]: ----------------------------------------------------------------- Jared is overloaded, dao, can you take a quick look here?
Attachment #8595852 -
Flags: review?(jaws) → review?(dao)
Comment 3•9 years ago
|
||
Comment on attachment 8595852 [details] [diff] [review] Bug1157143.patch Reducing the opacity might impair text rendering quality, i.e. disable sub-pixel AA. Adjusting the text color seems preferable. Also, why did you set the background-color to transparent? You already changed the other selectors setting a background-color to exclude disabled items.
Attachment #8595852 -
Flags: review?(dao) → review-
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #3) > Comment on attachment 8595852 [details] [diff] [review] > Bug1157143.patch > > Reducing the opacity might impair text rendering quality, i.e. disable > sub-pixel AA. Adjusting the text color seems preferable. Using now the Chameleon color #c1c1c1. > Also, why did you set the background-color to transparent? You already > changed the other selectors setting a background-color to exclude disabled > items. This is to override global/menu.css rules like: https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/menu.css#200 Linux and OS X do also have such definitions. I added a comment in code.
Attachment #8595852 -
Attachment is obsolete: true
Attachment #8600045 -
Flags: review?(dao)
Comment 5•9 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #4) > Created attachment 8600045 [details] [diff] [review] > Bug1157143.patch v2 > > (In reply to Dão Gottwald [:dao] from comment #3) > > Comment on attachment 8595852 [details] [diff] [review] > > Bug1157143.patch > > > > Reducing the opacity might impair text rendering quality, i.e. disable > > sub-pixel AA. Adjusting the text color seems preferable. > > Using now the Chameleon color #c1c1c1. I believe #333 with a 50% opacity against a white background would be #999...
Assignee | ||
Comment 6•9 years ago
|
||
Using #999 instead of #c1c1c1
Attachment #8600045 -
Attachment is obsolete: true
Attachment #8600045 -
Flags: review?(dao)
Attachment #8600061 -
Flags: review?(dao)
Updated•9 years ago
|
Attachment #8600061 -
Flags: review?(dao) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b56267ff0882
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•