1157143 - in-content/common.css: No indication when a menuitem is disabled

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: Screenshot 2015-04-21 15.29.31.png

From bug 989469 comment 148:

Heycam spotted another UI problem in the current patch, the "Ask to activate"
option for Open H264 is disabled but it appears enabled in the current patch.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug1157143.patch

The disabled menu/menuitems have now a opacity of 0.5 and no highlight on _moz-menuactive.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8595852 [details] [diff] [review]
Bug1157143.patch

Review of attachment 8595852 [details] [diff] [review]:
-----------------------------------------------------------------

Jared is overloaded, dao, can you take a quick look here?

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8595852 [details] [diff] [review]
Bug1157143.patch

Reducing the opacity might impair text rendering quality, i.e. disable sub-pixel AA. Adjusting the text color seems preferable.

Also, why did you set the background-color to transparent? You already changed the other selectors setting a background-color to exclude disabled items.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Bug1157143.patch v2

(In reply to Dão Gottwald [:dao] from comment #3)
> Comment on attachment 8595852 [details] [diff] [review]
> Bug1157143.patch
> 
> Reducing the opacity might impair text rendering quality, i.e. disable
> sub-pixel AA. Adjusting the text color seems preferable.

Using now the Chameleon color #c1c1c1.

> Also, why did you set the background-color to transparent? You already
> changed the other selectors setting a background-color to exclude disabled
> items.

This is to override global/menu.css rules like: https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/menu.css#200 Linux and OS X do also have such definitions. I added a comment in code.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Richard Marti (:Paenglab) from comment #4)
> Created attachment 8600045 [details] [diff] [review]
> Bug1157143.patch v2
> 
> (In reply to Dão Gottwald [:dao] from comment #3)
> > Comment on attachment 8595852 [details] [diff] [review]
> > Bug1157143.patch
> > 
> > Reducing the opacity might impair text rendering quality, i.e. disable
> > sub-pixel AA. Adjusting the text color seems preferable.
> 
> Using now the Chameleon color #c1c1c1.

I believe #333 with a 50% opacity against a white background would be #999...

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Bug1157143.patch v3

Using #999 instead of #c1c1c1

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b56267ff0882

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b56267ff0882