1157235 - Get rid of sessionstore-state-write notification

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

I'm a big fan of getting rid of notifications we don't need anymore and there are not tests or code using it. The only add-ons out there referencing it are either old and expect to still be able to modify the string or do not actually use it, it's just in the code there. Let's get rid of it.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1157235-Remove-unused-sessionstore-state-write-n.patch

Comment 2

[David Teller [:Yoric] - still alive but not very active]

I seemed to remember that Tor Browser was using it. Am I confusing with something else?

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

If found some tor browser button add-on (might be the official one) that tries to modify the string and set it to null before we write to disk. That possibility has been removed by us quite some time ago, and we do honor the permanent private browsing mode and don't save to disk at all. I remember we did consider Tor as a use case back when we did that.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

I remember that we got in touch with TBB devs before removing the string, but we didn't remove the notification entirely. I just sent an e-mail to get confirmation that removing the notification entirely will not break anything.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8595970 [details] [diff] [review]
0001-Bug-1157235-Remove-unused-sessionstore-state-write-n.patch

Review of attachment 8595970 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but let's wait until we have an answer from TBB devs before landing.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Good idea, thanks for doing that. We could probably also just needinfo? Mike here?

Comment 7

[Georg Koppen]

Okay, I looked at our code and I think we can just get rid of our session storage handling as |subject| in the notification is |null| anyway preventing us from stripping any data. As the logic is only active if the user is in non-private browsing mode (in private mode there is nothing saved to disk in the first place thanks to bug 944557) that is fine.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Thanks for the fast response, Georg!

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/61c9775d4aea

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/61c9775d4aea