Closed Bug 1157389 Opened 9 years ago Closed 9 years ago

In-content pages: Wrong spinbutton appearance on OS X

Categories

(Toolkit :: Themes, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file, 1 obsolete file)

From bug 989469 comment 126:

I did come across a bug while looking at that though, the spin buttons for options aren't styles right: https://www.dropbox.com/s/dy8gi1aoapa54dq/Screenshot%202015-04-13%2013.51.53.png?dl=0
Attached patch spinbuttons.patch (obsolete) — Splinter Review
Move the spinbutton rules from preferences.css to common.css.

I found also tabs instead of white spaces. I hope it's okay to fix it too in this bug.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8596102 - Flags: review?(jaws)
Blocks: 989469
(In reply to Richard Marti (:Paenglab) from comment #1)
> Created attachment 8596102 [details] [diff] [review]
> spinbuttons.patch
> 
> Move the spinbutton rules from preferences.css to common.css.
> 
> I found also tabs instead of white spaces. I hope it's okay to fix it too in
> this bug.

Oops, sorry for getting those in.
Attachment #8596102 - Flags: review?(jaws) → review+
Updated in commit message the reviewer.
Carrying over the r+
Attachment #8596102 - Attachment is obsolete: true
Attachment #8599916 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f327d13afcf9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.