1157433 - The Addon-SDK expects gContextMenuContentData to exist in the context menu code.

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Philip Chee]

http://forums.mozillazine.org/viewtopic.php?p=14093969#p14093969

console.error: no-eu-cookie-uk:
  Message: TypeError: this.contextMenuContentData is undefined
  Stack:
    updateItemVisibilities@resource://gre/modules/addons/XPIProvider.jsm ->
    jar:file:///C:/Users/lj/AppData/Roaming/Mozilla/SeaMonkey/Profiles/lmf7vii4.test2/extensions/[e-mail]!/bootstrap.js ->
    resource://gre/modules/commonjs/toolkit/loader.js ->
    resource://gre/modules/commonjs/sdk/context-menu.js:1015:11

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed implementation.

Firefox implementation:
http://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/content.js?rev=acd77f938db4&mark=135-224#135

> -function nsContextMenu(aXulMenu, aBrowser, aIsShift) {
> +function nsContextMenu(aXulMenu, aIsShift, aEvent) {

aBrowser was introduced for Firefox compatibility. Now that Firefox has removed that argument so should we.

Comment 2

[[e-mail]]

Comment on attachment 8596174 [details] [diff] [review]
Patch v1.0 Proposed implementation.

Seems reasonable.

Comment 3

[Philip Chee]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/5b258ec074d1

Comment 4

[Edmund Wong (:ewong)]

Comment on attachment 8596174 [details] [diff] [review]
Patch v1.0 Proposed implementation.

Review of attachment 8596174 [details] [diff] [review]:
-----------------------------------------------------------------

Noticed these while I updated the trunk for my bug 1099585 patch.  I'll fix these endings
on that patch if no one has any objections.

::: suite/common/nsContextMenu.js
@@ +63,5 @@
> +    };
> +    subject.wrappedJSObject = subject;
> +    // Notifies the Addon-SDK which then populates addonInfo.
> +    Services.obs.notifyObservers(subject, "content-contextmenu", null);
> +  

extra space nit.

@@ +74,5 @@
> +      try {
> +        let imageCache = Components.classes["@mozilla.org/image/tools;1"]
> +                                   .getService(Components.interfaces.imgITools)
> +                                   .getImgCacheForDocument(doc)
> +        let props = imageCache.findEntryProperties(popupNode.currentURI);

from line #75 - 77, there are CRLF endings.