Closed Bug 1157488 Opened 10 years ago Closed 10 years ago

Assert against re-entrant sync sections

Categories

(Core :: Widget, defect)

Product:
Core
Component:
Widget
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(2 files)

Assert against re-entrant sync sections. v1
3.28 KB, patch
bent.mozilla
: review+
Details | Diff | Splinter Review
Don't spin the event loop by synchronously dispatching when we're already on the main thread. v1
1.11 KB, patch
jwwang
: review+
Details | Diff | Splinter Review
This was the source of a hard-to-track-down bug in bug 1144486.
Attachment #8596225 - Flags: review?(bent.mozilla)
Comment on attachment 8596225 [details] [diff] [review] Assert against re-entrant sync sections. v1 Review of attachment 8596225 [details] [diff] [review]: ----------------------------------------------------------------- Ok
Attachment #8596225 - Flags: review?(bent.mozilla) → review+
(In reply to Bobby Holley (:bholley) from comment #3) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2dc4df4d3c6 Followup for the android orange, which was caused by not having the patch from comment 4: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e443c209dcc2
Attachment #8596287 - Flags: review?(jwwang) → review+
https://hg.mozilla.org/mozilla-central/rev/e436e20e5f2c https://hg.mozilla.org/mozilla-central/rev/7cd7611ed7b3
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Depends on: 1158761
Depends on: 1165350
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: