Closed Bug 1157503 Opened 5 years ago Closed 5 years ago
Tab Utils .extract Site should try-catch ns IURI .ascii Host
dveditz was seeing an exception in NewTabUtils.extractSite: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIURI.asciiHost] from NewTabUtils::extractSite nsIURI.asciiHost throws NS_ERROR_FAILURE for nsJARURI and nsMozIconURI, and indeed he had some jar URIs in his PlacesProvider's top sites.
Attachment #8596244 - Flags: feedback?(edilee)
Comment on attachment 8596244 [details] [diff] [review] patch No need for the extra uri and host variables anymore. We can just put the return newURI.asciiHost.replace directly in the try and catch return null because both try/catch blocks just return null. I suppose technically yes, .replace shouldn't throw and could be left outside of the try -- in this case, just a "let host" and one try block still.
Attachment #8596244 - Flags: feedback?(edilee) → feedback+
Attachment #8596654 - Flags: review?(ttaubert) → review+
Assignee: nobody → adw
Status: NEW → ASSIGNED
Comment on attachment 8602804 [details] [diff] [review] for aurora Approved for uplift to aurora as requested in bug 1161412.
Attachment #8602804 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.