1157503 - NewTabUtils.extractSite should try-catch nsIURI.asciiHost

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Drew Willcoxon :adw]

Attachment: patch

dveditz was seeing an exception in NewTabUtils.extractSite:

Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIURI.asciiHost]  from NewTabUtils::extractSite

nsIURI.asciiHost throws NS_ERROR_FAILURE for nsJARURI and nsMozIconURI, and indeed he had some jar URIs in his PlacesProvider's top sites.

Comment 1

[Ed Lee :Mardak]

Comment on attachment 8596244 [details] [diff] [review]
patch

No need for the extra uri and host variables anymore. We can just put the return newURI.asciiHost.replace directly in the try and catch return null because both try/catch blocks just return null. I suppose technically yes, .replace shouldn't throw and could be left outside of the try -- in this case, just a "let host" and one try block still.

Comment 2

[Drew Willcoxon :adw]

Attachment: patch v2

Comment 3

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/fx-team/rev/6ac6d95398cc

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6ac6d95398cc

Comment 5

[Ed Lee :Mardak]

Attachment: for aurora

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8602804 [details] [diff] [review]
for aurora

Approved for uplift to aurora as requested in bug 1161412.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/728c8bbc5843