1157534 - HomeBanner draws behind BrowserSearch, causing overdraw

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

Comment 1

[:Margaret Leibovic]

We hide the home banner when the keyboard is open, so won't this only happen if you dismiss the keyboard while searching? How often does that happen?

Maybe instead our logic should be to hide the home banner when the toolbar is in edit mode?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to :Margaret Leibovic from comment #1)
> We hide the home banner when the keyboard is open, so won't this only happen
> if you dismiss the keyboard while searching? How often does that happen?

True - but now this is causing issues for my solution in bug 1137483.

> Maybe instead our logic should be to hide the home banner when the toolbar
> is in edit mode?

A possible solution, but that would mean we would never see the HomeBanner from tapping on the url bar from existing tabs. I think it'd be more consistent to just tie the visibility of the HomeBanner to the visibility of the HomePager.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1157534/mcomella

/r/7513 - Bug 1157534 - Hide HomePagerContainer when showing BrowserSearch and vice versa. r=margaret

Pull down this commit:

hg pull -r b6cefaa098fafea182eb43dd1d0e14c5e5725e74 https://reviewboard-hg.mozilla.org/gecko/

Comment 4

[:Margaret Leibovic]

Comment on attachment 8596705 [details]
MozReview Request: bz://1157534/mcomella

https://reviewboard.mozilla.org/r/7511/#review6307

Nice catch, this is probably something we neglected to update when we implemented the home banner long ago.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/549be4ee6dca

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/549be4ee6dca

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1157534 - Hide HomePagerContainer when showing BrowserSearch and vice versa. r=margaret