Closed
Bug 1157534
Opened 10 years ago
Closed 10 years ago
HomeBanner draws behind BrowserSearch, causing overdraw
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(2 files, 1 obsolete file)
No description provided.
Comment 1•10 years ago
|
||
We hide the home banner when the keyboard is open, so won't this only happen if you dismiss the keyboard while searching? How often does that happen? Maybe instead our logic should be to hide the home banner when the toolbar is in edit mode?
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to :Margaret Leibovic from comment #1) > We hide the home banner when the keyboard is open, so won't this only happen > if you dismiss the keyboard while searching? How often does that happen? True - but now this is causing issues for my solution in bug 1137483. > Maybe instead our logic should be to hide the home banner when the toolbar > is in edit mode? A possible solution, but that would mean we would never see the HomeBanner from tapping on the url bar from existing tabs. I think it'd be more consistent to just tie the visibility of the HomeBanner to the visibility of the HomePager.
Assignee | ||
Comment 3•10 years ago
|
||
/r/7513 - Bug 1157534 - Hide HomePagerContainer when showing BrowserSearch and vice versa. r=margaret Pull down this commit: hg pull -r b6cefaa098fafea182eb43dd1d0e14c5e5725e74 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8596705 -
Flags: review?(margaret.leibovic)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → michael.l.comella
Comment 4•10 years ago
|
||
Comment on attachment 8596705 [details] MozReview Request: bz://1157534/mcomella https://reviewboard.mozilla.org/r/7511/#review6307 Nice catch, this is probably something we neglected to update when we implemented the home banner long ago.
Attachment #8596705 -
Flags: review?(margaret.leibovic) → review+
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/549be4ee6dca
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8596705 -
Attachment is obsolete: true
Attachment #8620119 -
Flags: review+
Assignee | ||
Comment 8•9 years ago
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•