Style guidelines: a spidermonkey can't change its spots

RESOLVED FIXED in Firefox 40

Status

()

Product:
Core
Component:
JavaScript Engine
Status:
RESOLVED FIXED
Reported:
4 years ago
Modified:
4 years ago

People

(Reporter: bbouvier, Assigned: bbouvier)

Tracking

Version:
Trunk
Target:
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

format.patch
54.88 KB, patch
jandem
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

•
4 years ago 
Created attachment 8596501 [details] [diff] [review]
format.patch

Courtesy of your script :)
Attachment #8596501 - Flags: review?(jdemooij)

Comment 2

•
4 years ago 
Comment on attachment 8596501 [details] [diff] [review]
format.patch

Review of attachment 8596501 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: js/src/vm/Shape.cpp
@@ +790,5 @@
>          if (!updateLast && !obj->generateOwnShape(cx))
>              return nullptr;
>  
>          /*
> +         * FIXME bug 593129 -- slot allocation and NativeObject* this must move

Nit: revert this change.
Attachment #8596501 - Flags: review?(jdemooij) → review+

Comment 4

•
4 years ago 
https://hg.mozilla.org/mozilla-central/rev/b7e1e4899a60
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.