Closed Bug 1157628 Opened 5 years ago Closed 5 years ago

Style guidelines: a spidermonkey can't change its spots

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

Details

Attachments

(1 file)

format.patch
54.88 KB, patch
jandem
: review+
Details | Diff | Splinter Review 
No description provided.
Attached patch format.patch — — Splinter Review 
Courtesy of your script :)
Attachment #8596501 - Flags: review?(jdemooij)
Comment on attachment 8596501 [details] [diff] [review]
format.patch

Review of attachment 8596501 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: js/src/vm/Shape.cpp
@@ +790,5 @@
>          if (!updateLast && !obj->generateOwnShape(cx))
>              return nullptr;
>  
>          /*
> +         * FIXME bug 593129 -- slot allocation and NativeObject* this must move

Nit: revert this change.
Attachment #8596501 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/b7e1e4899a60
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.