Closed
Bug 1157628
Opened 10 years ago
Closed 10 years ago
Style guidelines: a spidermonkey can't change its spots
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
Details
Attachments
(1 file)
54.88 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Courtesy of your script :)
Attachment #8596501 -
Flags: review?(jdemooij)
Comment 2•10 years ago
|
||
Comment on attachment 8596501 [details] [diff] [review]
format.patch
Review of attachment 8596501 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks.
::: js/src/vm/Shape.cpp
@@ +790,5 @@
> if (!updateLast && !obj->generateOwnShape(cx))
> return nullptr;
>
> /*
> + * FIXME bug 593129 -- slot allocation and NativeObject* this must move
Nit: revert this change.
Attachment #8596501 -
Flags: review?(jdemooij) → review+
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•