1157628 - Style guidelines: a spidermonkey can't change its spots

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: format.patch

Courtesy of your script :)

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8596501 [details] [diff] [review]
format.patch

Review of attachment 8596501 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: js/src/vm/Shape.cpp
@@ +790,5 @@
>          if (!updateLast && !obj->generateOwnShape(cx))
>              return nullptr;
>  
>          /*
> +         * FIXME bug 593129 -- slot allocation and NativeObject* this must move

Nit: revert this change.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7e1e4899a60

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b7e1e4899a60