Closed Bug 1157637 Opened 6 years ago Closed 6 years ago
Bar Handler and Gecko Selection Carets tests
Work on bug 988143 pointed out an issue with the core/Gecko SelectionCarets code, which we corrected in bug 1156037. This provides a good case to start work on the new test infra we'll need before final cut-over from the original Android carets. Posting and cc:ing for now... I'll r? to margaret later ... we still have approvals outstanding on bug 988143 before we get to hers. After that we'll tag her with this one also ;-)
Comment on attachment 8596885 [details] [diff] [review] bug1157637.diff Pulling review om this ... It needs some refinements to get past the TRY server.
This is tighter than the first one. Also see: https://treeherder.mozilla.org/#/jobs?repo=try&revision=983be19d8072 (all oranges unrelated to this test).
Nice converted version ... works well at home, no push to try yet.
Push to try, trigger buncha times looking for random oranges ... found none :-) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecbbc0937cfc
Attachment #8601004 - Flags: review?(margaret.leibovic) → feedback+
Comment on attachment 8602685 [details] [diff] [review] bug1157637_testSelectionCarets.diff Review of attachment 8602685 [details] [diff] [review]: ----------------------------------------------------------------- If it's green on try, good to go! ::: mobile/android/tests/browser/robocop/testSelectionCarets.js @@ +164,5 @@ > + yield do_promiseTabChangeEvent(BrowserApp.selectedTab.id, TAB_STOP_EVENT); > + > + // Ensure Gecko Selection and Touch carets are enabled. > + Services.prefs.setBoolPref(SELECTION_CARETS_PREF, true); > + Services.prefs.setBoolPref(TOUCH_CARET_PREF, true); We should also clear these prefs in the cleanup function below.
Attachment #8602685 - Flags: review?(margaret.leibovic) → review+
Final push to TRY https://treeherder.mozilla.org/#/jobs?repo=try&revision=b85b860c0ae2
You need to log in before you can comment on or make changes to this bug.