1157644 - TelemetryEnvironment is not triggering environment changes when preferences are changed

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Alessio Placitelli [:Dexter]]

TelemetryEnvironment is not notifying environment changes when a watched preference is changed even though |test_TelemetryEnvironment.js| works.

This is happening because in [1] we're not correctly iterating the preferences Map. We've got different solutions for this:

- [1] could be changed to |for (let pref of this._watchedPrefs.keys()) {| and the tests updated accordingly to use a |Map| instead of a javascript object.
- [2] could be changed to the form |{"the.prop": TelemetryEnvironment.PREF_STATE,}|, leaving the tests as they are.

[1] - https://hg.mozilla.org/mozilla-central/annotate/a9311ec2dd39/toolkit/components/telemetry/TelemetryEnvironment.jsm#l779
[2] - https://hg.mozilla.org/mozilla-central/annotate/a9311ec2dd39/toolkit/components/telemetry/TelemetryEnvironment.jsm#l79

Comment 1

[Alessio Placitelli [:Dexter]]

Attachment: bug1157644.patch

This patch fixes environment changes not being triggered on pref changes.

Comment 2

[Benjamin Smedberg]

Comment on attachment 8597242 [details] [diff] [review]
bug1157644.patch

stealing review

Comment 3

[Alessio Placitelli [:Dexter]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec0fc5144c53

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/2a22a1013ae0

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2a22a1013ae0