1157664 - Uninitialized member mozilla::layers::FPSCounter::mIteratorIndex in constructor

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

This is benign but adds to the coverity warning noise, so let's fix it.

Comment 1

[mathieu.blot]

Hello, I would like to work on that bug, please.

Comment 2

[mathieu.blot]

Do FPSCounter::mIteratorIndex need to be initialized to a specific value ?

Comment 3

[Nicolas Silva [:nical]]

(In reply to mathieu.blot from comment #2)
> Do FPSCounter::mIteratorIndex need to be initialized to a specific value ?

-1 will do. It's an invalid value so it will trigger assertions if we ever forget to initialize mIteratorIndex when starting to iterate.

Comment 4

[mathieu.blot]

Attachment: Build successful

Comment 5

[Nicolas Silva [:nical]]

Comment on attachment 8607571 [details] [diff] [review]
Build successful

Review of attachment 8607571 [details] [diff] [review]:
-----------------------------------------------------------------

Move that up one line and you'll have the r+ :)

::: gfx/layers/composite/FPSCounter.cpp
@@ +29,5 @@
>  
>  FPSCounter::FPSCounter(const char* aName)
>    : mWriteIndex(0)
>    , mFPSName(aName)
> +  , mIteratorIndex(-1)

Please initialize members in the same order they are declared (mIterator comes before mFPSName).

Comment 6

[mathieu.blot]

Attachment: Build successful

Initializations in the same order as the definition of the members.

Comment 7

[Carsten Book [:Tomcat]]

can we get a try run for this ?

Comment 8

[Paul Adenot (:padenot)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f60ff9177143

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8964d03d9599

Comment 10

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/8964d03d9599