1157665 - marionette_driver is missing mozrunner dependency

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Andreas Tolfsen ❲:ato❳]

geckoinstance.py depends on mozrunner and it's missing from requirements.txt.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: bz://1157665/ato

/r/7489 - Bug 1157665: Add mozrunner dependency to marionette_driver

Pull down this commit:

hg pull -r 7e9b4b09c45e31cc842ddcb4e596df40ea8ceb3e https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=538f0b525b5e

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8596544 [details]
MozReview Request: bz://1157665/ato

https://reviewboard.mozilla.org/r/7487/#review6269

::: testing/marionette/client/setup.py:3
(Diff revision 1)
> -version = '0.11'
> +version = '0.12'

Why are you bumping the version of marionette-client when it's marionette-driver that's changed?

::: testing/marionette/driver/requirements.txt:2
(Diff revision 1)
> +mozrunner >= 6.2

Does this mean we can also remove the mozrunner requirement from marionette-client?

Comment 4

[Andreas Tolfsen ❲:ato❳]

https://reviewboard.mozilla.org/r/7487/#review6283

> Does this mean we can also remove the mozrunner requirement from marionette-client?

It's still in use by a test:

% g mozrunner
./requirements.txt:7:mozrunner >= 6.2
./marionette/tests/unit/test_screen_orientation.py:9:from mozrunner.devices.emulator_screen import EmulatorScreen

> Why are you bumping the version of marionette-client when it's marionette-driver that's changed?

Oops, pushing a fixup.

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8596544 [details]
MozReview Request: bz://1157665/ato

/r/7489 - Bug 1157665: Add mozrunner dependency to marionette_driver

Pull down this commit:

hg pull -r 71e92e750ee4a8a82fd6cb3f5a12a4018d0c1984 https://reviewboard-hg.mozilla.org/gecko/

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8596544 [details]
MozReview Request: bz://1157665/ato

https://reviewboard.mozilla.org/r/7487/#review6297

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

https://reviewboard.mozilla.org/r/7487/#review6295

> It's still in use by a test:
> 
> % g mozrunner
> ./requirements.txt:7:mozrunner >= 6.2
> ./marionette/tests/unit/test_screen_orientation.py:9:from mozrunner.devices.emulator_screen import EmulatorScreen

Okay, although I think these tests only apply to the marionette-driver so should probably be moved, and should not depend on the requirements of marionette-client.

Comment 9

[Andreas Tolfsen ❲:ato❳]

(In reply to Dave Hunt (:davehunt) from comment #7)
> https://reviewboard.mozilla.org/r/7487/#review6295
> 
> > It's still in use by a test:
> > 
> > % g mozrunner
> > ./requirements.txt:7:mozrunner >= 6.2
> > ./marionette/tests/unit/test_screen_orientation.py:9:from mozrunner.devices.emulator_screen import EmulatorScreen
> 
> Okay, although I think these tests only apply to the marionette-driver so
> should probably be moved, and should not depend on the requirements of
> marionette-client.

We should probably do that.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db2bf088e4f8

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/db2bf088e4f8

Comment 12

[Armen [:armenzg]]

Could someone with permission please release this new version to pypi?
I filed bug 1159421 for this purpose.

Thanks!

Comment 14

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1157665: Add mozrunner dependency to marionette_driver

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Moving bugs for Marionette client due to component changes.