bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Should ignore query string / hashes for checking for "home page"

VERIFIED FIXED in Firefox 38.0.5

Status

()

Toolkit
Reader Mode
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Trunk
mozilla40
Points:
2
Bug Flags:
firefox-backlog +
in-testsuite -
qe-verify +

Firefox Tracking Flags

(firefox38 wontfix, firefox38.0.5 verified, firefox39 verified, firefox40 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
Iteration: --- → 40.2 - 27 Apr
Points: --- → 2
Flags: qe-verify+
Flags: in-testsuite-
Flags: firefox-backlog+
(Assignee)

Comment 1

3 years ago
Created attachment 8596584 [details]
MozReview Request: bz://1157682/Gijs

/r/7497 - Bug 1157682 - ignore querystring / hash when determining 'home page' for reader mode, r?margaret

Pull down this commit:

hg pull -r 6ae1fd9e91389b3699515006016247b6ee6f5c2b https://reviewboard-hg.mozilla.org/gecko/
(Assignee)

Updated

3 years ago
Attachment #8596584 - Flags: review?(margaret.leibovic)
(Assignee)

Comment 2

3 years ago
As a side effect, this will also fix bug 1151087, at least for bing.

Comment 3

3 years ago
Comment on attachment 8596584 [details]
MozReview Request: bz://1157682/Gijs

https://reviewboard.mozilla.org/r/7495/#review6285

::: toolkit/components/reader/ReaderMode.jsm:250
(Diff revision 1)
> +    } catch (ex) { /* ignore if this doesn't work */ }

When would this not work? If `uri` can't be turned into an `nsIURL`, maybe we should just return false, since I would assume it isn't a well formatted URL.
Attachment #8596584 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 5

3 years ago
Comment on attachment 8596584 [details]
MozReview Request: bz://1157682/Gijs

Approval Request Comment
[Feature/regressing bug #]: reader mode
[User impact if declined]: reader mode offered on pages where it shouldn't be
[Describe test coverage new/current, TreeHerder]: not for this specific part
[Risks and why]: pretty low, restricted to how/when we offer reader mode
[String/UUID change made/needed]: no.
Attachment #8596584 - Flags: approval-mozilla-release?
Attachment #8596584 - Flags: approval-mozilla-beta?
Attachment #8596584 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/836194cdafc4
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
status-firefox38: --- → affected
status-firefox39: --- → affected
Comment on attachment 8596584 [details]
MozReview Request: bz://1157682/Gijs

We are late in the beta cycle. I would like to take it only for 38.0.5.
Attachment #8596584 - Flags: approval-mozilla-release?
Attachment #8596584 - Flags: approval-mozilla-release-
Attachment #8596584 - Flags: approval-mozilla-beta?
Attachment #8596584 - Flags: approval-mozilla-beta+
Attachment #8596584 - Flags: approval-mozilla-aurora?
Attachment #8596584 - Flags: approval-mozilla-aurora+
QA Contact: andrei.vaida
status-firefox38: fixed → wontfix
status-firefox38.0.5: --- → fixed
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 40.0a1 (buildID: 20150511030203), latest Aurora 39.0a2 (buildID: 20150511004005) and Firefox 38.0.5 Beta 1 (buildID: 20150510205200).
Status: RESOLVED → VERIFIED
status-firefox38.0.5: fixed → verified
status-firefox39: fixed → verified
status-firefox40: fixed → verified
(Assignee)

Comment 11

3 years ago
Comment on attachment 8596584 [details]
MozReview Request: bz://1157682/Gijs
Attachment #8596584 - Attachment is obsolete: true
Attachment #8620133 - Flags: review+
(Assignee)

Comment 12

3 years ago
Created attachment 8620133 [details]
MozReview Request: Bug 1157682 - ignore querystring / hash when determining 'home page' for reader mode, r?margaret
You need to log in before you can comment on or make changes to this bug.