1157682 - Should ignore query string / hashes for checking for "home page"

Status: VERIFIED FIXED

(Toolkit :: Reader Mode, defect)

Description

[:Gijs (out for now; he/him)]

Context: https://github.com/mozilla/readability/issues/173

Comment 1

[:Gijs (out for now; he/him)]

Attachment: MozReview Request: bz://1157682/Gijs

/r/7497 - Bug 1157682 - ignore querystring / hash when determining 'home page' for reader mode, r?margaret

Pull down this commit:

hg pull -r 6ae1fd9e91389b3699515006016247b6ee6f5c2b https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[:Gijs (out for now; he/him)]

As a side effect, this will also fix bug 1151087, at least for bing.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8596584 [details]
MozReview Request: bz://1157682/Gijs

https://reviewboard.mozilla.org/r/7495/#review6285

::: toolkit/components/reader/ReaderMode.jsm:250
(Diff revision 1)
> +    } catch (ex) { /* ignore if this doesn't work */ }

When would this not work? If `uri` can't be turned into an `nsIURL`, maybe we should just return false, since I would assume it isn't a well formatted URL.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/836194cdafc4

Comment 5

[:Gijs (out for now; he/him)]

Comment on attachment 8596584 [details]
MozReview Request: bz://1157682/Gijs

Approval Request Comment
[Feature/regressing bug #]: reader mode
[User impact if declined]: reader mode offered on pages where it shouldn't be
[Describe test coverage new/current, TreeHerder]: not for this specific part
[Risks and why]: pretty low, restricted to how/when we offer reader mode
[String/UUID change made/needed]: no.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/836194cdafc4

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8596584 [details]
MozReview Request: bz://1157682/Gijs

We are late in the beta cycle. I would like to take it only for 38.0.5.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d1779f598935

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/624da87ca18e

Comment 10

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 40.0a1 (buildID: 20150511030203), latest Aurora 39.0a2 (buildID: 20150511004005) and Firefox 38.0.5 Beta 1 (buildID: 20150510205200).

Comment 12

[:Gijs (out for now; he/him)]

Attachment: MozReview Request: Bug 1157682 - ignore querystring / hash when determining 'home page' for reader mode, r?margaret