|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
39 bytes, text/x-review-board-request
|Details | Review|
Confirmed on two independent runs. Appears to only affect WinXP (exciting, I know). Also goes away on trunk-as-beta simulation pushes, so maybe DevEdition-related somehow? Unfortunately, my earlier simulation pushes were caught up in total Win32 bustage from a JS PGO issue, so I can't say for sure when this regressed. Current Gecko 39 Aurora isn't affected. https://treeherder.mozilla.org/logviewer.html#?job_id=6875560&repo=try 01:36:13 INFO - TEST-START | test_mouse_action.py TestMouseAction.test_double_click_action 01:36:13 ERROR - TEST-UNEXPECTED-FAIL | test_mouse_action.py TestMouseAction.test_double_click_action | AssertionError: u'quux' != 'Displayed' 01:36:13 INFO - Traceback (most recent call last): 01:36:13 INFO - File "C:\slave\test\build\venv\lib\site-packages\marionette\marionette_test.py", line 296, in run 01:36:13 INFO - testMethod() 01:36:13 INFO - File "C:\slave\test\build\tests\marionette\tests\testing\marionette\client\marionette\tests\unit\test_mouse_action.py", line 46, in test_double_click_action 01:36:13 INFO - self.assertEqual(rel.get_attribute('value'), 'Displayed') 01:36:13 INFO - TEST-INFO took 296ms
This test looks a little flaky, I'll look at rewriting it but may have to disable for that platform if this needs to happen soon.
Didn't mean to cancel flag
This test relies on a behavior where marionette will automatically scroll us into view, and then double clicks to select a word. My best guess is we're out of sync with the scroll and the test fails because it never selects the word. I rewrote the test to do the double click without relying on the scroll. Let's hope that does the trick. Here it is on try on top of the trunk as aurora patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8ffed637858
That looks good. Here's opt as well: https://treeherder.mozilla.org/#/jobs?repo=try&revision=86b2f910d173
Created attachment 8597036 [details] MozReview Request: bz://1157725/chmanchester /r/7577 - Bug 1157725 - Rewrite test_mouse_action.py to be more robust. Pull down this commit: hg pull -r 0805c82b621999d9dcec563abb87d1cd7609092d https://reviewboard-hg.mozilla.org/gecko/
Attachment #8597036 - Flags: review?(ato)
Comment on attachment 8597036 [details] MozReview Request: bz://1157725/chmanchester https://reviewboard.mozilla.org/r/7575/#review6365 Ship It!
Attachment #8597036 - Flags: review?(ato) → review+
Assignee: nobody → cmanchester
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
A fresh set of pushes says this is fixed :)
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
Comment on attachment 8597036 [details] MozReview Request: bz://1157725/chmanchester
Created attachment 8620137 [details] MozReview Request: Bug 1157725 - Rewrite test_mouse_action.py to be more robust.
You need to log in before you can comment on or make changes to this bug.