test_mouse_action.py is going to permafail on WinXP when Gecko 40 merges to Aurora

VERIFIED FIXED in Firefox 40

Status

--
critical
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: RyanVM, Assigned: chmanchester)

Tracking

Trunk
mozilla40
x86
Windows XP
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox40 verified)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Confirmed on two independent runs. Appears to only affect WinXP (exciting, I know). Also goes away on trunk-as-beta simulation pushes, so maybe DevEdition-related somehow?

Unfortunately, my earlier simulation pushes were caught up in total Win32 bustage from a JS PGO issue, so I can't say for sure when this regressed. Current Gecko 39 Aurora isn't affected.

https://treeherder.mozilla.org/logviewer.html#?job_id=6875560&repo=try

01:36:13 INFO - TEST-START | test_mouse_action.py TestMouseAction.test_double_click_action
01:36:13 ERROR - TEST-UNEXPECTED-FAIL | test_mouse_action.py TestMouseAction.test_double_click_action | AssertionError: u'quux' != 'Displayed'
01:36:13 INFO - Traceback (most recent call last):
01:36:13 INFO - File "C:\slave\test\build\venv\lib\site-packages\marionette\marionette_test.py", line 296, in run
01:36:13 INFO - testMethod()
01:36:13 INFO - File "C:\slave\test\build\tests\marionette\tests\testing\marionette\client\marionette\tests\unit\test_mouse_action.py", line 46, in test_double_click_action
01:36:13 INFO - self.assertEqual(rel.get_attribute('value'), 'Displayed')
01:36:13 INFO - TEST-INFO took 296ms
Flags: needinfo?(cmanchester)
(Assignee)

Comment 1

3 years ago
This test looks a little flaky, I'll look at rewriting it but may have to disable for that platform if this needs to happen soon.
Flags: needinfo?(cmanchester)
(Assignee)

Comment 2

3 years ago
Didn't mean to cancel flag
Flags: needinfo?(cmanchester)
(Assignee)

Comment 3

3 years ago
This test relies on a behavior where marionette will automatically scroll us into view, and then double clicks to select a word. My best guess is we're out of sync with the scroll and the test fails because it never selects the word. I rewrote the test to do the double click without relying on the scroll.

Let's hope that does the trick. Here it is on try on top of the trunk as aurora patches:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8ffed637858
Flags: needinfo?(cmanchester)
(Assignee)

Comment 5

3 years ago
Created attachment 8597036 [details]
MozReview Request: bz://1157725/chmanchester

/r/7577 - Bug 1157725 - Rewrite test_mouse_action.py to be more robust.

Pull down this commit:

hg pull -r 0805c82b621999d9dcec563abb87d1cd7609092d https://reviewboard-hg.mozilla.org/gecko/
Attachment #8597036 - Flags: review?(ato)
Comment on attachment 8597036 [details]
MozReview Request: bz://1157725/chmanchester

https://reviewboard.mozilla.org/r/7575/#review6365

Ship It!
Attachment #8597036 - Flags: review?(ato) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Reporter)

Comment 7

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/16e5e2afd14c
Assignee: nobody → cmanchester
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/16e5e2afd14c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
(Reporter)

Comment 9

3 years ago
A fresh set of pushes says this is fixed :)
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
(Assignee)

Comment 10

3 years ago
Comment on attachment 8597036 [details]
MozReview Request: bz://1157725/chmanchester
Attachment #8597036 - Attachment is obsolete: true
Attachment #8620137 - Flags: review+
(Assignee)

Comment 11

3 years ago
Created attachment 8620137 [details]
MozReview Request: Bug 1157725 - Rewrite test_mouse_action.py to be more robust.
You need to log in before you can comment on or make changes to this bug.