Closed
Bug 1157758
Opened 9 years ago
Closed 9 years ago
in vertical writing mode with upright glyph orientation, Arabic-script shaping should not be applied
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
377.84 KB,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
2.68 KB,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
Testcase: data:text/html;charset=utf-8, <div style="writing-mode:vertical-rl;text-orientation:upright">الخط العربي Should render the Arabic letters in their isolated ("unshaped") form.[1] (This is a harfbuzz issue; PR submitted upstream.[2] Once it is fixed there, we'll resolve the Gecko bug by taking a new harfbuzz version.) [1] http://dev.w3.org/csswg/css-writing-modes/#typeset-upright [2] https://github.com/behdad/harfbuzz/pull/100
Assignee | ||
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b13cdf89efc2
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8597609 -
Flags: review?(jdaggett)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Updated•9 years ago
|
Attachment #8597609 -
Flags: review?(jdaggett) → review+
Comment 3•9 years ago
|
||
It would be nice to have a reftest for this since no actual user is ever going to care about this codepath... :P
Assignee | ||
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e735e4040d7e
Assignee | ||
Comment 5•9 years ago
|
||
Here's a reftest that seems to work locally; if tryserver doesn't like it on some platforms, we might need to add a specific Arabic font to ensure consistent behavior, but let's see.
Attachment #8603209 -
Flags: review?(jdaggett)
Updated•9 years ago
|
Attachment #8603209 -
Flags: review?(jdaggett) → review+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2aabff6bd77 https://hg.mozilla.org/integration/mozilla-inbound/rev/876a0813cdc5
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e2aabff6bd77 https://hg.mozilla.org/mozilla-central/rev/876a0813cdc5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•