Closed Bug 1157865 Opened 5 years ago Closed 5 years ago

Tablet: Anchor Site Identity popup under back button

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 40
Tracking Status
firefox39 --- verified
firefox40 --- verified

People

(Reporter: liuche, Assigned: liuche)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Summary: Tbalet: Anchor Site Identity popup under back button → Tablet: Anchor Site Identity popup under back button
Attached file MozReview Request: bz://1157865/liuche (obsolete) —
/r/7565 - Bug 1157865 - Tablet: Anchor Site Identity popup under the back button. r=ally

Pull down this commit:

hg pull -r f7085e07aa5b89b1406c24a6f2fa48b9c64b4309 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8596978 - Flags: review?(ally)
Comment on attachment 8596978 [details]
MozReview Request: bz://1157865/liuche

https://reviewboard.mozilla.org/r/7563/#review6387

Ship It!
Attachment #8596978 - Flags: review?(ally) → review+
https://hg.mozilla.org/mozilla-central/rev/f0dd7524cbf3
Assignee: nobody → liuche
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Comment on attachment 8596978 [details]
MozReview Request: bz://1157865/liuche

Approval Request Comment
[Feature/regressing bug #]: bug 1155819 - Missed one case of tablet re-anchoring
[User impact if declined]: Tablet users will see misplaced doorhanger for site identity
[Describe test coverage new/current, TreeHerder]: baking on nightly, local testing
[Risks and why]: low, wrapping up last case for doorhanger positioning that was missed
[String/UUID change made/needed]: none
Attachment #8596978 - Flags: approval-mozilla-aurora?
Verified as fixed using:
Device: Asus Transformer (Android 4.0.3)
Build: Firefox for Android 40.0a1 (2015-04-29)
Tested with mixed content blocking and site identity doorhangers (tapping the grey lock from gmail.com, green lock from addons.mozilla.org or the globe favicon).
Comment on attachment 8596978 [details]
MozReview Request: bz://1157865/liuche

Approved for uplift to 39. Looks low-risk, and this has been verified fixed on nightly.
Attachment #8596978 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Tested with: 
Device: Asus Transformer (Android 4.0.3).
Build: Firefox for Android 39.0a1 (2015-05-07)

Tested with mixed content blocking and site identity doorhangers (tapping the grey lock from gmail.com, green lock from addons.mozilla.org).
Status: RESOLVED → VERIFIED
Attachment #8596978 - Attachment is obsolete: true
Attachment #8620142 - Flags: review+
You need to log in before you can comment on or make changes to this bug.