11579 - nsMsgDatabase::HasNew() has broken use of NS_COMFALSE

Status: VERIFIED FIXED

(MailNews Core :: Database, defect, P3)

Description

[John Bandhauer]

nsMsgDatabase::HasNew() returns either NS_OK (0) or NS_COMFALSE (1).

nsMsgDatabase::GetFirstNew() checks for NS_SUCCEEDED(HasNew()) which is always
true even if m_newSet is NULL;

This will crash.

nsMsgDBFolder::ReadDBFolderInfo checks for '!db->HasNew()' which is either
broken or confusing.

NS_COMFALSE generally sucks.

Comment 1

[scottputterman]

setting M10

Comment 2

[(not reading, please use [e-mail] instead)]

fixed checked in.

HasNew() has been rewritten.

Comment 3

[(not reading, please use [e-mail] instead)]

jband will have to verify, as it is in the source.

Comment 4

[(not reading, please use [e-mail] instead)]

marking m9 and fixed.

Comment 5

[John Bandhauer]

Seth,

Was the old usage of HasNew() in nsMsgDBFolder.cpp broken?

It used to say '!db->HasNew()' and now it says '!hasnew'. These look the
same, but this function used to return NS_OK (which equals zero) for 'yes' and
now returns PR_TRUE for 'yes'. So either it was broken before, or it seems to
me, this change breaks it.

Just want to be sure.

John.

Comment 6

[(not reading, please use [e-mail] instead)]

putterman has reviewed my code, and also believes it to be correct.

jband, thanks for the heads up.

Comment 7

[fenella]

Scott and Seth, please advise QA how to verify this bug.  If you believe this
cannot be verified by QA, please let me know.  I'll take your words and mark
Verified.
Thanks,
Fenella

Comment 8

[(not reading, please use [e-mail] instead)]

marking verified for fenella.

HasNew() no longer uses NS_COMFALSE

See:
http://lxr.mozilla.org/seamonkey/source/mailnews/db/msgdb/src/nsMsgDatabase.cpp#1538

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5500345457d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11579 - Adds telemetry for autoplay settings in Site Permissions