Closed Bug 1157966 Opened 9 years ago Closed 7 years ago

UITour.jsm gets imported for every session due to UITour.onLocationChange

Categories

(Firefox :: Tours, defect)

Product:
Firefox
Component:
Tours
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox51 --- wontfix
firefox52 --- wontfix
firefox-esr52 --- wontfix
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [Memshrink:P2] [fixed by bug 1342462]) 

Since most sessions don't involve tours, we should try to avoid importing UITour.jsm by default. Bug 1134501 made UITour.jsm get called from onLocationChange so everyone gets it loaded now.

See https://mxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserGlue.js#3016
Should we move the regex url check into browser.js ? Other suggestions? Not really sure how to avoid this situation...
Flags: needinfo?(MattN+bmo)
(In reply to :Gijs Kruitbosch from comment #1)
> Should we move the regex url check into browser.js ? Other suggestions?

Yeah, anywhere other than UITour.jsm. IMO it doesn't really belong in there anyways since the reading tour is a consumer of UITour and the code isn't about UITour functionality itself.
Flags: needinfo?(MattN+bmo)
Whiteboard: [Memshrink] → [Memshrink:P2]
Depends on: 1342462
I confirmed in a build with the fix from bug 1342462 that UITour.jsm doesn't appear in the debugger script list after startup (without using about:home since it uses UITour).
Assignee: nobody → MattN+bmo
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Memshrink:P2] → [Memshrink:P2] [fixed by bug 1342462]
You need to log in before you can comment on or make changes to this bug.