Allow deleting bookmarks from the UI

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wesj, Unassigned)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fennec+)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
We should let you swipe to remove bookmarks in the bookmark list.
(Reporter)

Comment 1

3 years ago
Created attachment 8597033 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/374

This code is a bit... messy. Didn't show up until I tried to do more. I need to write some tests here, but I'm out for a few days. Figured I'd put this up.
Attachment #8597033 - Flags: review?(rnewman)

Updated

3 years ago
tracking-fennec: --- → ?
Argh, this review request never made it into my inbox :/

My rnewman/db branch has deletion (by URL -- i.e., unstar), parenting, mobile bookmarks, folders, and such, and also has killed BookmarksSqlite, so this PR might be obsolete :(

Sorry!
I'm gonna grab what I can out of this on top of the bleeding edge.
Comment on attachment 8597033 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/374

UI stuff is rebased into https://github.com/mozilla/firefox-ios/pull/405, and will land with that.
Attachment #8597033 - Flags: review?(rnewman) → review+
tracking-fennec: ? → +
(Reporter)

Comment 5

3 years ago
This landed, but I actually can't see anything on the bookmarks panel anymore.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.