1158144 - Implement "Copy POST Parameters" context menu item

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Jan Keromnes [:janx]]

Feature from Firebug's net panel. Example:

1. Head to http://codepad.org/
2. Open the Network panel
3. Click on "Submit"

Right-click on the first request item (sent as POST) should have a "Copy POST Parameters" option, that copies form data like so:

code=
lang=C
run=True
submit=Submit

Comment 1

[Jan Keromnes [:janx]]

Attachment: Fix "Copy URL Parameters" line separation on Windows.

Drive-by fix.

Comment 2

[Jan Keromnes [:janx]]

Attachment: Implement "Copy POST Data" context menu item.

Comment 3

[Jan Keromnes [:janx]]

Comment on attachment 8605872 [details] [diff] [review]
Fix "Copy URL Parameters" line separation on Windows.

Drive-by fix: In a previous patch, I forgot to use `string` instead of `params.join("\n")`, causing single-line pastes in Windows' Notepad.

Victor, please have a look.

Comment 4

[Jan Keromnes [:janx]]

Comment on attachment 8605873 [details] [diff] [review]
Implement "Copy POST Data" context menu item.

One of the last context menu items before Firebug-parity.
I had to factor out some form data code.
Victor, please have a look.

Comment 5

[Victor Porof [:vporof][:vp]]

Comment on attachment 8605872 [details] [diff] [review]
Fix "Copy URL Parameters" line separation on Windows.

Review of attachment 8605872 [details] [diff] [review]:
-----------------------------------------------------------------

wut

Comment 6

[Victor Porof [:vporof][:vp]]

Comment on attachment 8605873 [details] [diff] [review]
Implement "Copy POST Data" context menu item.

Review of attachment 8605873 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 7

[Jan Keromnes [:janx]]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c950600f18cd

Comment 8

[Jan Keromnes [:janx]]

Tentative "checkin-needed", but the oranges look worrying. Please don't land if they persist.

Comment 9

[Jan Keromnes [:janx]]

Not to worry, I submitted that try push twice, and the other one doesn't have oranges:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d542c5340d7a

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c52d801739f0
https://hg.mozilla.org/integration/fx-team/rev/86b65bc7f08f

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c52d801739f0
https://hg.mozilla.org/mozilla-central/rev/86b65bc7f08f

Comment 12

[Jan Keromnes [:janx]]

Comment on attachment 8605872 [details] [diff] [review]
Fix "Copy URL Parameters" line separation on Windows.

Please uplift this fix to Firefox40 (Aurora).

[Feature/regressing bug #]: "Copy URL Parameters" context menu added by bug 1150717 has a surprizing result on Windows (no line breaks in legacy editors like Notepad).

[User impact if declined]: "Copy URL Parameters" will continue to paste as a single line in Windows editors like Notepad.

[Describe test coverage new/current, TreeHerder]: The test only use single parameters, so the multi-line issue wasn't detected early.

[Risks and why]: No risk, it's a trivial fix.

[String/UUID change made/needed]: None.

Comment 13

[Jan Keromnes [:janx]]

Comment on attachment 8605873 [details] [diff] [review]
Implement "Copy POST Data" context menu item.

Please uplift this new context menu item to Firefox40 (Aurora).

[Feature/regressing bug #]: None (gap from Firebug).

[User impact if declined]: Users won't be able to copy POST data using the context menu.

[Describe test coverage new/current, TreeHerder]: This uses the same test as "Copy URL Parameters", but adds a few checks for POST data.

[Risks and why]: Small. Some adjacent code was lightly refactored, and a test was modified.

[String/UUID change made/needed]: New `netmonitorUI.context.copyPostData` string + access key.

Comment 14

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I'd like to get this into aurora for June 2. As has been discussed a few times with l10n people, strings in devtools are often not translated as it is, and in this case the string in question is almost entirely technical jargon so I don't consider adding a new string here to be a huge problem.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8605872 [details] [diff] [review]
Fix "Copy URL Parameters" line separation on Windows.

Let's take it in 40. Anyway, I know how to find you in case of regression ;)

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3f530bf2d385
https://hg.mozilla.org/releases/mozilla-aurora/rev/120fabccc4ff

Comment 17

[Ryan VanderMeulen [:RyanVM]]

CCing Pike about the string addition.

Comment 18

[Axel Hecht [:Pike]]

Ugh, talking to us and getting to the same resolution doesn't seem to be the same thing, apparently.

We hard-coded the strings to English in the other devtools bugs.

Comment 19

[Francesco Lodolo [:flod]]

(In reply to Jeff Griffiths (:canuckistani) from comment #14)
> I'd like to get this into aurora for June 2. As has been discussed a few
> times with l10n people, strings in devtools are often not translated as it
> is, and in this case the string in question is almost entirely technical
> jargon so I don't consider adding a new string here to be a huge problem.

The question should have really come before landing the strings (the bug Pike is referring to is bug 1163763).