Closed
Bug 1158144
Opened 9 years ago
Closed 9 years ago
Implement "Copy POST Parameters" context menu item
Categories
(DevTools :: Netmonitor, defect, P1)
DevTools
Netmonitor
Tracking
(firefox40 fixed, firefox41 fixed)
RESOLVED
FIXED
Firefox 41
People
(Reporter: janx, Assigned: janx)
References
(Blocks 1 open bug)
Details
(Whiteboard: [polish-backlog][difficulty=easy])
Attachments
(2 files)
1.03 KB,
patch
|
vporof
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
17.05 KB,
patch
|
vporof
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Feature from Firebug's net panel. Example: 1. Head to http://codepad.org/ 2. Open the Network panel 3. Click on "Submit" Right-click on the first request item (sent as POST) should have a "Copy POST Parameters" option, that copies form data like so: code= lang=C run=True submit=Submit
Assignee | ||
Comment 1•9 years ago
|
||
Drive-by fix.
Assignee | ||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8605872 [details] [diff] [review] Fix "Copy URL Parameters" line separation on Windows. Drive-by fix: In a previous patch, I forgot to use `string` instead of `params.join("\n")`, causing single-line pastes in Windows' Notepad. Victor, please have a look.
Attachment #8605872 -
Flags: review?(vporof)
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8605873 [details] [diff] [review] Implement "Copy POST Data" context menu item. One of the last context menu items before Firebug-parity. I had to factor out some form data code. Victor, please have a look.
Attachment #8605873 -
Flags: review?(vporof)
Comment 5•9 years ago
|
||
Comment on attachment 8605872 [details] [diff] [review] Fix "Copy URL Parameters" line separation on Windows. Review of attachment 8605872 [details] [diff] [review]: ----------------------------------------------------------------- wut
Attachment #8605872 -
Flags: review?(vporof) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8605873 [details] [diff] [review] Implement "Copy POST Data" context menu item. Review of attachment 8605873 [details] [diff] [review]: ----------------------------------------------------------------- LGTM!
Attachment #8605873 -
Flags: review?(vporof) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Thanks! https://treeherder.mozilla.org/#/jobs?repo=try&revision=c950600f18cd
Assignee | ||
Comment 8•9 years ago
|
||
Tentative "checkin-needed", but the oranges look worrying. Please don't land if they persist.
Keywords: checkin-needed
Assignee | ||
Comment 9•9 years ago
|
||
Not to worry, I submitted that try push twice, and the other one doesn't have oranges: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d542c5340d7a
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c52d801739f0 https://hg.mozilla.org/integration/fx-team/rev/86b65bc7f08f
Keywords: checkin-needed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c52d801739f0 https://hg.mozilla.org/mozilla-central/rev/86b65bc7f08f
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8605872 [details] [diff] [review] Fix "Copy URL Parameters" line separation on Windows. Please uplift this fix to Firefox40 (Aurora). [Feature/regressing bug #]: "Copy URL Parameters" context menu added by bug 1150717 has a surprizing result on Windows (no line breaks in legacy editors like Notepad). [User impact if declined]: "Copy URL Parameters" will continue to paste as a single line in Windows editors like Notepad. [Describe test coverage new/current, TreeHerder]: The test only use single parameters, so the multi-line issue wasn't detected early. [Risks and why]: No risk, it's a trivial fix. [String/UUID change made/needed]: None.
Attachment #8605872 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 13•9 years ago
|
||
Comment on attachment 8605873 [details] [diff] [review] Implement "Copy POST Data" context menu item. Please uplift this new context menu item to Firefox40 (Aurora). [Feature/regressing bug #]: None (gap from Firebug). [User impact if declined]: Users won't be able to copy POST data using the context menu. [Describe test coverage new/current, TreeHerder]: This uses the same test as "Copy URL Parameters", but adds a few checks for POST data. [Risks and why]: Small. Some adjacent code was lightly refactored, and a test was modified. [String/UUID change made/needed]: New `netmonitorUI.context.copyPostData` string + access key.
Attachment #8605873 -
Flags: approval-mozilla-aurora?
Comment 14•9 years ago
|
||
I'd like to get this into aurora for June 2. As has been discussed a few times with l10n people, strings in devtools are often not translated as it is, and in this case the string in question is almost entirely technical jargon so I don't consider adding a new string here to be a huge problem.
Updated•9 years ago
|
status-firefox40:
--- → affected
Comment 15•9 years ago
|
||
Comment on attachment 8605872 [details] [diff] [review] Fix "Copy URL Parameters" line separation on Windows. Let's take it in 40. Anyway, I know how to find you in case of regression ;)
Attachment #8605872 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Attachment #8605873 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 16•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/3f530bf2d385 https://hg.mozilla.org/releases/mozilla-aurora/rev/120fabccc4ff
Flags: in-testsuite+
Comment 17•9 years ago
|
||
CCing Pike about the string addition.
Comment 18•9 years ago
|
||
Ugh, talking to us and getting to the same resolution doesn't seem to be the same thing, apparently. We hard-coded the strings to English in the other devtools bugs.
Comment 19•9 years ago
|
||
(In reply to Jeff Griffiths (:canuckistani) from comment #14) > I'd like to get this into aurora for June 2. As has been discussed a few > times with l10n people, strings in devtools are often not translated as it > is, and in this case the string in question is almost entirely technical > jargon so I don't consider adding a new string here to be a huge problem. The question should have really come before landing the strings (the bug Pike is referring to is bug 1163763).
Updated•9 years ago
|
Whiteboard: [devedition-40][difficulty=easy] → [polish-backlog][difficulty=easy]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•