Closed
Bug 1158249
Opened 10 years ago
Closed 9 years ago
watchLength is NaN
Categories
(Chat Core :: IRC, defect)
Chat Core
IRC
Tracking
(Not tracked)
RESOLVED
FIXED
Instantbird 43
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(1 file)
|
1.26 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Error: Maximum size for WATCH list exceeded (NaN). Source File: resource://gre/modules/ircWatchMonitor.jsm Line: 186 Source Code: prpl-irc: ircWATCH.commands[512]
|
|
Assignee | |
Comment 2•9 years ago
|
||
Fixes the NaN, doesn't do anything clever like adding the nicks over the limit to ISON.
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8656110 [details] [diff] [review]
watchlength.diff
Review of attachment 8656110 [details] [diff] [review]:
-----------------------------------------------------------------
I think this will fix the bug. I'm unsure that that error message actually makes a ton of sense. (I wish this had tests...) Thanks!
Attachment #8656110 -
Flags: review?(clokep) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to Patrick Cloke [:clokep] from comment #3)
> Comment on attachment 8656110 [details] [diff] [review]
> watchlength.diff
>
> Review of attachment 8656110 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> I think this will fix the bug. I'm unsure that that error message actually
> makes a ton of sense. (I wish this had tests...) Thanks!
From the comment in the code, it looks like your idea was "if I ever see this error message, I should take care of the TODO" ;)
Keywords: checkin-needed
|
|
Assignee | |
Comment 5•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/f2c4f6f1dd59fd76d84509458313b2d3d61c9dbc
Bug 1158249 - watchLength is NaN. r=clokep
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 43
You need to log in
before you can comment on or make changes to this bug.
Description
•