watchLength is NaN

RESOLVED FIXED in Instantbird 43

Status

Chat Core
IRC
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

trunk
Instantbird 43

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Error: Maximum size for WATCH list exceeded (NaN). Source File: resource://gre/modules/ircWatchMonitor.jsm Line: 186 Source Code: prpl-irc: ircWATCH.commands[512]
(Assignee)

Comment 2

2 years ago
Created attachment 8656110 [details] [diff] [review]
watchlength.diff

Fixes the NaN, doesn't do anything clever like adding the nicks over the limit to ISON.
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Attachment #8656110 - Flags: review?(clokep)
Comment on attachment 8656110 [details] [diff] [review]
watchlength.diff

Review of attachment 8656110 [details] [diff] [review]:
-----------------------------------------------------------------

I think this will fix the bug. I'm unsure that that error message actually makes a ton of sense. (I wish this had tests...) Thanks!
Attachment #8656110 - Flags: review?(clokep) → review+
(Assignee)

Comment 4

2 years ago
(In reply to Patrick Cloke [:clokep] from comment #3)
> Comment on attachment 8656110 [details] [diff] [review]
> watchlength.diff
> 
> Review of attachment 8656110 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I think this will fix the bug. I'm unsure that that error message actually
> makes a ton of sense. (I wish this had tests...) Thanks!

From the comment in the code, it looks like your idea was "if I ever see this error message, I should take care of the TODO" ;)
Keywords: checkin-needed
(Assignee)

Comment 5

2 years ago
https://hg.mozilla.org/comm-central/rev/f2c4f6f1dd59fd76d84509458313b2d3d61c9dbc
Bug 1158249 - watchLength is NaN. r=clokep
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 43
You need to log in before you can comment on or make changes to this bug.