1158319 - Cache API should throw NS_ERROR_DOM_SECURITY_ERR if principal is incorrect

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Right now CacheStorage is throwing NS_ERROR_FAILURE which is gecko specific.  We can be slightly better here and throw NS_ERROR_DOM_SECURITY_ERR.  Neither is really spec'd as far as I can tell.  The SecurityError seems better for now, though.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Cache should throw SecurityError if the principal is incorrect. r=ehsan

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Cache should throw SecurityError if the principal is incorrect. r=ehsan

Try again without a bunch of unrelated changes.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Raised a spec issue:

  https://github.com/slightlyoff/ServiceWorker/issues/687

We are matching what blink does for now.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/3e548b8fed23

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3e548b8fed23