Closed Bug 1158322 Opened 10 years ago Closed 10 years ago

Sidebar affects a page while printing

Categories

(Toolkit :: Reader Mode, defect)

Product:
Toolkit
Component:
Reader Mode
Version:
39 Branch
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla40
Iteration:
40.2 - 27 Apr
Tracking Flags:
Tracking Status
firefox38 --- unaffected
firefox38.0.5 --- verified
firefox39 --- verified
firefox40 --- verified

People

(Reporter: jakub1996, Assigned: Gijs)

References

Details

Attachments

(2 files, 1 obsolete file)

test.pdf
139.56 KB, application/pdf
Details
MozReview Request: Bug 1158322 - force-display-none the toolbar and footer when printing, r?margaret
39 bytes, text/x-review-board-request
Margaret
: review+
Details
Attached file test.pdf —
User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:37.0) Gecko/20100101 Firefox/37.0 Build ID: 20150407092154 Steps to reproduce: 1. Open an article in reader view. Example page: http://bentnib.org/posts/2015-04-17-propositions-as-filenames-essence-of-make.html 2. Print/print to file Actual results: When printing, the controls of read viewer cover the content of article. The sidebar appears on every printed page, making the print useless. Expected results: Sidebar shouldn't be visible.
this is happing in both nightly and aurora 40.0a1 (2015-04-23) 39.0a2 (2015-04-23) gavin can you take a look at this for me.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(gavin.sharp)
I thought this was something :margaret addressed in some bug somewhere?
Flags: needinfo?(gavin.sharp) → needinfo?(margaret.leibovic)
Blocks: 1135009
this seems to be bug 1135009 happening again, seem to be broken again somewhere down the line
This is because the toolbar's explicitly set to display: block in a style attribute, and that overrides the display: none in the print media query.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
status-firefox38: --- → affected
status-firefox39: --- → affected
status-firefox40: --- → affected
Flags: qe-verify+
Flags: needinfo?(margaret.leibovic)
Flags: in-testsuite-
Flags: firefox-backlog+
Iteration: --- → 40.2 - 27 Apr
Points: --- → 1
Component: Untriaged → Reader Mode
Product: Firefox → Toolkit
Attached file MozReview Request: bz://1158322/Gijs (obsolete) —
/r/7655 - Bug 1158322 - force-display-none the toolbar and footer when printing, r?margaret Pull down this commit: hg pull -r 9584f2b4b183eac079776b13c88b37c437342434 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8597513 - Flags: review?(margaret.leibovic)
Attachment #8597513 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8597513 [details] MozReview Request: bz://1158322/Gijs https://reviewboard.mozilla.org/r/7653/#review6457 Ship It!
https://hg.mozilla.org/mozilla-central/rev/48296982c44a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
QA Contact: andrei.vaida
Reproduced with Nightly 2015-04-24 under Mac OSX 10.9.5. Verified as fixed with latest Nightly 40.0a1 (2015-04-29) on Mac OSX 10.9.5, Ubuntu 14.04 x32 and Windows 7 x64.
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
Do we need to uplift this?
Flags: needinfo?(gijskruitbosch+bugs)
Comment on attachment 8597513 [details] MozReview Request: bz://1158322/Gijs Yes, this should get uplifted. Approval Request Comment [Feature/regressing bug #]: reader mode printing [User impact if declined]: side bar prints [Describe test coverage new/current, TreeHerder]: nope :-( [Risks and why]: essentially 0, minor CSS change that only affects printing (inside @media (print) ), already verified by QA [String/UUID change made/needed]: nope
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8597513 - Flags: approval-mozilla-beta?
Attachment #8597513 - Flags: approval-mozilla-aurora?
Comment on attachment 8597513 [details] MozReview Request: bz://1158322/Gijs Should be in 38.0.5beta1
Attachment #8597513 - Flags: approval-mozilla-beta?
Attachment #8597513 - Flags: approval-mozilla-beta+
Attachment #8597513 - Flags: approval-mozilla-aurora?
Attachment #8597513 - Flags: approval-mozilla-aurora+
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Aurora 39.0a2 (buildID: 20150511004005) and Firefox 38.0.5 Beta 1 (buildID: 20150510205200).
status-firefox38.0.5: fixed → verified
status-firefox39: fixed → verified
Attachment #8597513 - Attachment is obsolete: true
Attachment #8620158 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: