Closed Bug 1158322 Opened 7 years ago Closed 7 years ago
Sidebar affects a page while printing
User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:37.0) Gecko/20100101 Firefox/37.0 Build ID: 20150407092154 Steps to reproduce: 1. Open an article in reader view. Example page: http://bentnib.org/posts/2015-04-17-propositions-as-filenames-essence-of-make.html 2. Print/print to file Actual results: When printing, the controls of read viewer cover the content of article. The sidebar appears on every printed page, making the print useless. Expected results: Sidebar shouldn't be visible.
this is happing in both nightly and aurora 40.0a1 (2015-04-23) 39.0a2 (2015-04-23) gavin can you take a look at this for me.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I thought this was something :margaret addressed in some bug somewhere?
Flags: needinfo?(gavin.sharp) → needinfo?(margaret.leibovic)
this seems to be bug 1135009 happening again, seem to be broken again somewhere down the line
This is because the toolbar's explicitly set to display: block in a style attribute, and that overrides the display: none in the print media query.
Component: Untriaged → Reader Mode
Product: Firefox → Toolkit
/r/7655 - Bug 1158322 - force-display-none the toolbar and footer when printing, r?margaret Pull down this commit: hg pull -r 9584f2b4b183eac079776b13c88b37c437342434 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8597513 - Flags: review?(margaret.leibovic)
Attachment #8597513 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8597513 [details] MozReview Request: bz://1158322/Gijs https://reviewboard.mozilla.org/r/7653/#review6457 Ship It!
Reproduced with Nightly 2015-04-24 under Mac OSX 10.9.5. Verified as fixed with latest Nightly 40.0a1 (2015-04-29) on Mac OSX 10.9.5, Ubuntu 14.04 x32 and Windows 7 x64.
Do we need to uplift this?
Comment on attachment 8597513 [details] MozReview Request: bz://1158322/Gijs Yes, this should get uplifted. Approval Request Comment [Feature/regressing bug #]: reader mode printing [User impact if declined]: side bar prints [Describe test coverage new/current, TreeHerder]: nope :-( [Risks and why]: essentially 0, minor CSS change that only affects printing (inside @media (print) ), already verified by QA [String/UUID change made/needed]: nope
Comment on attachment 8597513 [details] MozReview Request: bz://1158322/Gijs Should be in 38.0.5beta1
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Aurora 39.0a2 (buildID: 20150511004005) and Firefox 38.0.5 Beta 1 (buildID: 20150510205200).
You need to log in before you can comment on or make changes to this bug.