Closed Bug 1158366 Opened 9 years ago Closed 9 years ago

Remove several unused XPIDL element interfaces

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: khuey, Assigned: khuey)

Details

(Keywords: addon-compat, dev-doc-complete)

Attachments

(1 file)

Attached patch PatchSplinter Review
These all have no uses in the tree and zero or one uses in the addons MXR.
Attachment #8597479 - Flags: review?(ehsan)
Comment on attachment 8597479 [details] [diff] [review]
Patch

Review of attachment 8597479 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/HTMLTitleElement.cpp
@@ +43,3 @@
>  {
> +  if (!nsContentUtils::GetNodeTextContent(this, false, aText)) {
> +    aError = NS_ERROR_OUT_OF_MEMORY;

Nit: .Throw()
Attachment #8597479 - Flags: review?(ehsan) → review+
Apparently using the INTERFACE_TABLE macros with nothing in them causes bad things to happen.

Trying a fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8359c02aaa5
Flags: needinfo?(khuey)
https://hg.mozilla.org/mozilla-central/rev/0bebb0ae2e39
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
This change is now mentioned on Firefox 40 for developers: https://developer.mozilla.org/en-US/Firefox/Releases/40#XPCOM

Unable to find other obvious places to mention it, so calling this fixed.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: