1158377 - Link drag-and-drop doesn't work properly when viewing source from a remote browser

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1) Open an e10s browser tab
2) Cmd/Ctrl-U to open the view source window
3) Drag a link onto the view source window from any web page

ER:

The source for the link should be shown.

AR:

The content for the link is loaded in the view source browser instead.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: bz://1158377/mconley

/r/8381 - Bug 1158377 - Make link drag-and-drop work with view source windows opened on remote browsers. r=?

Pull down this commit:

hg pull -r 8baa158a4e6e110b6b7fc12cc1ec1a236a63bd42 https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Before trying your patch, I did the following test:

1. Open https://www.mozilla.org/en-US/ in e10s
2. Cmd-U to open View Source
3. Drag the "Firefox" link onto the View Source window

I got the source of https://www.mozilla.org/en-US/firefox/products/ in the view source window.

So, is your patch needed?  What am I missing?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #2)
> Before trying your patch, I did the following test:
> 
> 1. Open https://www.mozilla.org/en-US/ in e10s
> 2. Cmd-U to open View Source
> 3. Drag the "Firefox" link onto the View Source window
> 
> I got the source of https://www.mozilla.org/en-US/firefox/products/ in the
> view source window.
> 
> So, is your patch needed?  What am I missing?

Sorry, I should have made it more specific - I broke this functionality with that bigass refactor I did of view source a few weeks back in bug 1025146. That patch is still blocked from landing, but while testing it, I noticed that I had broken link drag and drop.

So this fixes that eventual breakage. In order to test, you can pull directly down from MozReview via:

hg pull -r 8baa158a4e6e110b6b7fc12cc1ec1a236a63bd42 https://reviewboard-hg.mozilla.org/gecko/

And then go back one commit to get into the broken state. Alternatively, you can apply bug 1156493, then bug 1025146, to get into the broken state, and then apply this bug patch to get it working again.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Ah yes, I think that should have been obvious, sorry.  Taking another look now!

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8602966 [details]
MozReview Request: bz://1158377/mconley

https://reviewboard.mozilla.org/r/8379/#review7105

Ship It!

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

This looks good!  But, I noticed some new issues with bug 1025146 while testing that I've reported there.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2529d411d5b1

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2529d411d5b1

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1158377 - Make link drag-and-drop work with view source windows opened on remote browsers. r=?