Closed Bug 1158377 Opened 6 years ago Closed 6 years ago

Link drag-and-drop doesn't work properly when viewing source from a remote browser

Categories

(Toolkit :: View Source, defect)

36 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
e10s m7+ ---
firefox41 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file, 1 obsolete file)

STR:

1) Open an e10s browser tab
2) Cmd/Ctrl-U to open the view source window
3) Drag a link onto the view source window from any web page

ER:

The source for the link should be shown.

AR:

The content for the link is loaded in the view source browser instead.
Assignee: nobody → mconley
/r/8381 - Bug 1158377 - Make link drag-and-drop work with view source windows opened on remote browsers. r=?

Pull down this commit:

hg pull -r 8baa158a4e6e110b6b7fc12cc1ec1a236a63bd42 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8602966 - Flags: review?(jryans)
Before trying your patch, I did the following test:

1. Open https://www.mozilla.org/en-US/ in e10s
2. Cmd-U to open View Source
3. Drag the "Firefox" link onto the View Source window

I got the source of https://www.mozilla.org/en-US/firefox/products/ in the view source window.

So, is your patch needed?  What am I missing?
Flags: needinfo?(mconley)
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #2)
> Before trying your patch, I did the following test:
> 
> 1. Open https://www.mozilla.org/en-US/ in e10s
> 2. Cmd-U to open View Source
> 3. Drag the "Firefox" link onto the View Source window
> 
> I got the source of https://www.mozilla.org/en-US/firefox/products/ in the
> view source window.
> 
> So, is your patch needed?  What am I missing?

Sorry, I should have made it more specific - I broke this functionality with that bigass refactor I did of view source a few weeks back in bug 1025146. That patch is still blocked from landing, but while testing it, I noticed that I had broken link drag and drop.

So this fixes that eventual breakage. In order to test, you can pull directly down from MozReview via:

hg pull -r 8baa158a4e6e110b6b7fc12cc1ec1a236a63bd42 https://reviewboard-hg.mozilla.org/gecko/

And then go back one commit to get into the broken state. Alternatively, you can apply bug 1156493, then bug 1025146, to get into the broken state, and then apply this bug patch to get it working again.
Flags: needinfo?(mconley)
Ah yes, I think that should have been obvious, sorry.  Taking another look now!
Comment on attachment 8602966 [details]
MozReview Request: bz://1158377/mconley

https://reviewboard.mozilla.org/r/8379/#review7105

Ship It!
Attachment #8602966 - Flags: review?(jryans) → review+
This looks good!  But, I noticed some new issues with bug 1025146 while testing that I've reported there.
https://hg.mozilla.org/mozilla-central/rev/2529d411d5b1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Attachment #8602966 - Attachment is obsolete: true
Attachment #8620159 - Flags: review+
You need to log in before you can comment on or make changes to this bug.