Closed
Bug 115842
Opened 23 years ago
Closed 23 years ago
Use "fgrep" instead of "grep" in build code where usefull
Categories
(SeaMonkey :: Build Config, enhancement)
Tracking
(Not tracked)
VERIFIED
WONTFIX
People
(Reporter: roland.mainz, Assigned: netscape)
Details
Looking at configure.in:
There are a lot of places where we do a simple check for a string via "grep"
without using a regex.
It may be nice to use "fgrep" instead of "grep" because it's slightly faster (no
regex precompilation).
For example:
-- snip --
if test -z "$MOZ_JSDEBUGGER" && test `echo "$MOZ_EXTENSIONS" | grep -c venkman`
-ne 0; then
AC_MSG_WARN([Cannot build venkman without JavaScript debug library. Removing
venkman from MOZ_EXTENSIONS.])
MOZ_EXTENSIONS=`echo $MOZ_EXTENSIONS | sed -e 's|venkman||'`
fi
-- snip --
Can be turned into:
-- snip --
if test -z "$MOZ_JSDEBUGGER" && test `echo "$MOZ_EXTENSIONS" | fgrep -c venkman`
-ne 0; then
AC_MSG_WARN([Cannot build venkman without JavaScript debug library. Removing
venkman from MOZ_EXTENSIONS.])
MOZ_EXTENSIONS=`echo $MOZ_EXTENSIONS | sed -e 's|venkman||'`
fi
-- snip --
Assignee | ||
Comment 1•23 years ago
|
||
I'll fix occurrences as I find them but I'm not dedicating time to this.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•