1158437 - dom::File totally mishandles negative modification dates

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This:

  (new File([], { lastModified: -1 })).lastModified

returns 1429928122205.  That's busted.

So is the fact that (new File([], { lastModified: -1000 })).lastModified returns
1429928167714 (which is _bigger_ than the other value).

Per spec, lastModified is signed, and negative values are perfectly OK.  Why is our impl storing it unsigned?

Comment 1

[Andrea Marchesini [:baku]]

Attachment: date.patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8597688 [details] [diff] [review]
date.patch

Could you add some test that 
lastModifiedDate returns something sane.
http://mxr.mozilla.org/mozilla-central/source/dom/webidl/File.webidl#45

Comment 3

[Andrea Marchesini [:baku]]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=2137146549d6

https://treeherder.mozilla.org/#/jobs?repo=try&revision=495a5641d994

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2137146549d6