1158517 - Fix remaining keyboard jshint issues

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Kevin Grandon :kgrandon]

Which means removing these files from xfail.list: https://github.com/mozilla-b2g/gaia/blob/65b44a9346539f9178ff42f2416875b4cafef415/build/jshint/xfail.list#L50-L63

We're getting close to being done with jshint fixes and can kill off some legacy code once we do so. Let's push this through!

Comment 1

[Kevin Grandon :kgrandon]

Rudy or Jan - would either of you guys be interested in taking this? If not, I'm more than happy to work on it and request review from one of you. Thanks!

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, sure, I'll take it.

Kevin, thanks for the heads-up.

Comment 3

[Kevin Grandon :kgrandon]

Hey Rudy - just curious as to where this is on your priority list. We have patches in progress for most of the remaining apps, except keyboard. Any chance you're going to get to this soon? If not, I'm more than happy to take it and maybe mark you or Tim for review. Just let me know, thanks!

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I could get to this today or next Monday, (tomorrow is a holiday for Taiwan).
If that's ok, please let me handle this or feel free to take it if you need to get this done this week.

Thanks.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1158517 > mozilla-b2g:master

Comment 6

[[e-mail]]

Comment on attachment 8600125 [details] [review]
[gaia] gasolin:issue-1158517 > mozilla-b2g:master

I've go through and fix all keyboard lint issues. Though I feel it need some knowledge in imes to make sure comment out unused methods not break anything.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8600125 [details] [review]
[gaia] gasolin:issue-1158517 > mozilla-b2g:master

It seems this change fails the unit tests and build integration tests of keyboard, so clear the feedback flag first.
Please help address the test failure, or let me know if I need to take over from here.

I also left some comments on the changes on pull request.

Thanks for your help to look into this!

Comment 8

[[e-mail]]

Comment on attachment 8600125 [details] [review]
[gaia] gasolin:issue-1158517 > mozilla-b2g:master

Tests fixed. The main issue I encountered is lack of document about how to run keyboard build test and update new dictionary sizes to test resources. Thanks Rudy's help for provide those key information.

To mitigate test related issues that other contributors might also encountered, I've put a README.md that address above issues. Please kindly review it.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8600125 [details] [review]
[gaia] gasolin:issue-1158517 > mozilla-b2g:master

r=me with some nits to address.
Please help take a look at my comments on pr.

Thanks a lot for working on this!

Comment 10

[[e-mail]]

thanks!

Comment 11

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/29823

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 12

[Kevin Grandon :kgrandon]

Treestatus shows gaia as open, so adding checkin-needed again to notify autolander.

Comment 13

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/18b322aef7f508ddcf0cc5fadf912d978a826407